refactor(clippy): resolve idiomatic lint warnings

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

5 files changed, 11 insertions, 13 deletions

diff --git a/crates/shirabe/src/dependency_resolver/rule_set_generator.rs b/crates/shirabe/src/dependency_resolver/rule_set_generator.rs
index d9452a3..5ec027b 100644
--- a/crates/shirabe/src/dependency_resolver/rule_set_generator.rs
+++ b/crates/shirabe/src/dependency_resolver/rule_set_generator.rs
@@ -167,7 +167,7 @@ impl RuleSetGenerator {
                 work_queue.push_back(alias_of.clone());
                 let rule = self.create_require_rule(
                     package.clone(),
-                    &[alias_of.clone()],
+                    std::slice::from_ref(&alias_of),
                     rule::RULE_PACKAGE_ALIAS,
                     rule::ReasonData::BasePackage(package.clone()),
                 );
@@ -176,7 +176,7 @@ impl RuleSetGenerator {
                 // aliases must be installed with their main package, so create a rule the other way around as well
                 let inverse_rule = self.create_require_rule(
                     alias_of.clone(),
-                    &[package.clone()],
+                    std::slice::from_ref(&package),
                     rule::RULE_PACKAGE_INVERSE_ALIAS,
                     rule::ReasonData::BasePackage(alias_of.clone()),
                 );
@@ -325,7 +325,7 @@ impl RuleSetGenerator {
             self.add_rules_for_package(package.clone(), platform_requirement_filter);
 
             let rule = self.create_install_one_of_rule(
-                &[package.clone()],
+                std::slice::from_ref(package),
                 rule::RULE_FIXED,
                 rule::ReasonData::Fixed {
                     package: package.clone(),
diff --git a/crates/shirabe/src/downloader/vcs_downloader.rs b/crates/shirabe/src/downloader/vcs_downloader.rs
index 993d18a..482a343 100644
--- a/crates/shirabe/src/downloader/vcs_downloader.rs
+++ b/crates/shirabe/src/downloader/vcs_downloader.rs
@@ -462,8 +462,8 @@ pub trait VcsDownloader:
     }
 
     fn prepare_urls(&self, mut urls: Vec<String>) -> Vec<String> {
-        for index in 0..urls.len() {
-            let mut url = urls[index].clone();
+        for url_entry in &mut urls {
+            let mut url = url_entry.clone();
             if Filesystem::is_local_path(&url) {
                 // realpath() below will not understand
                 // url that starts with "file://"
@@ -479,10 +479,10 @@ pub trait VcsDownloader:
                     url = rawurldecode(&url);
                 }
 
-                urls[index] = realpath(&url).unwrap_or_default();
+                *url_entry = realpath(&url).unwrap_or_default();
 
                 if is_file_protocol {
-                    urls[index] = format!("{}{}", file_protocol, urls[index]);
+                    *url_entry = format!("{}{}", file_protocol, url_entry);
                 }
             }
         }
diff --git a/crates/shirabe/src/repository/composer_repository.rs b/crates/shirabe/src/repository/composer_repository.rs
index 618d375..f35be80 100644
--- a/crates/shirabe/src/repository/composer_repository.rs
+++ b/crates/shirabe/src/repository/composer_repository.rs
@@ -1698,7 +1698,7 @@ impl ComposerRepository {
                 || StabilityFilter::is_package_acceptable(
                     acceptable_stabilities.unwrap(),
                     stability_flags.unwrap(),
-                    &[name.clone()],
+                    std::slice::from_ref(&name),
                     "dev",
                 )
             {
diff --git a/crates/shirabe/src/repository/vcs/gitlab_driver.rs b/crates/shirabe/src/repository/vcs/gitlab_driver.rs
index a5e6b73..0bc933e 100644
--- a/crates/shirabe/src/repository/vcs/gitlab_driver.rs
+++ b/crates/shirabe/src/repository/vcs/gitlab_driver.rs
@@ -604,8 +604,8 @@ impl GitLabDriver {
     fn url_encode_all(&self, string: &str) -> String {
         let mut encoded = String::new();
         let bytes: Vec<char> = string.chars().collect();
-        for i in 0..bytes.len() {
-            let character = bytes[i].to_string();
+        for byte in &bytes {
+            let character = byte.to_string();
             let final_character = if !ctype_alnum(&character)
                 && !in_array(
                     PhpMixed::String(character.clone()),
diff --git a/crates/shirabe/src/util/git.rs b/crates/shirabe/src/util/git.rs
index 1467a29..5923917 100644
--- a/crates/shirabe/src/util/git.rs
+++ b/crates/shirabe/src/util/git.rs
@@ -174,8 +174,7 @@ impl Git {
             let mut outputs: Vec<String> = vec![];
 
             let mut status: i64 = 0;
-            let mut counter: i64 = 0;
-            for callable in &command_callables {
+            for (counter, callable) in command_callables.iter().enumerate() {
                 let cmd = callable(url_arg);
                 *last_cmd = PhpMixed::List(
                     cmd.iter()
@@ -195,7 +194,6 @@ impl Git {
                 if status != 0 {
                     break;
                 }
-                counter += 1;
             }
 
             if collect_outputs && let Some(out) = command_output {