diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 03:25:06 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 03:25:06 +0900 |
| commit | c4e7f0b77938b28522ce0c94824bb53a57ba4c88 (patch) | |
| tree | 68a6a265f6a1e81eec1a8173f0c6fff934125db5 /crates/shirabe | |
| parent | 96a8ff0513ae7b012b3e4ba8e43a3eca71847458 (diff) | |
| download | php-shirabe-c4e7f0b77938b28522ce0c94824bb53a57ba4c88.tar.gz php-shirabe-c4e7f0b77938b28522ce0c94824bb53a57ba4c88.tar.zst php-shirabe-c4e7f0b77938b28522ce0c94824bb53a57ba4c88.zip | |
test(diagnose-command): detail ignore reasons with the actual blocker
The tests fail before any network access: DiagnoseCommand::check_platform
captures phpinfo() via ob_start()/ob_get_clean(), which are todo!() in
shirabe-php-shim, so the command panics before producing output. Record
that as the primary blocker alongside the live-network requirement.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe')
| -rw-r--r-- | crates/shirabe/tests/command/diagnose_command_test.rs | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/crates/shirabe/tests/command/diagnose_command_test.rs b/crates/shirabe/tests/command/diagnose_command_test.rs index 1bd0c6ac..95c713ff 100644 --- a/crates/shirabe/tests/command/diagnose_command_test.rs +++ b/crates/shirabe/tests/command/diagnose_command_test.rs @@ -7,8 +7,11 @@ use shirabe_php_shim::PhpMixed; #[test] #[serial] -#[ignore = "diagnose checks live http/https connectivity to packagist and the github.com rate \ - limit, so it requires real network access"] +#[ignore = "DiagnoseCommand::check_platform captures phpinfo() via ob_start()/ob_get_clean(), \ + which are todo!() in shirabe-php-shim (PHP output buffering and runtime introspection \ + are unmodeled), so the command panics before producing output; beyond that, diagnose \ + checks live http/https connectivity to packagist and the github.com rate limit, so the \ + test also requires real network access (as the PHP original does)"] fn test_cmd_fail() { let tear_down = init_temp_composer( Some(&serde_json::json!({ "name": "foo/bar", "description": "test pkg" })), @@ -48,8 +51,11 @@ Checking github.com rate limit: " #[test] #[serial] -#[ignore = "diagnose checks live http/https connectivity to packagist and the github.com rate \ - limit, so it requires real network access"] +#[ignore = "DiagnoseCommand::check_platform captures phpinfo() via ob_start()/ob_get_clean(), \ + which are todo!() in shirabe-php-shim (PHP output buffering and runtime introspection \ + are unmodeled), so the command panics before producing output; beyond that, diagnose \ + checks live http/https connectivity to packagist and the github.com rate limit, so the \ + test also requires real network access (as the PHP original does)"] fn test_cmd_success() { let tear_down = init_temp_composer( Some(&serde_json::json!({ |