diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-05 00:30:29 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-05 00:32:15 +0900 |
| commit | a73e44e327776ac4ba79737eea6b6ad00cf00da6 (patch) | |
| tree | 812a3dc7d49edb6724c7fbd744c63813c8009563 /crates | |
| parent | b36410024e46a7de5314af6549ba39bf88fe598c (diff) | |
| download | php-shirabe-a73e44e327776ac4ba79737eea6b6ad00cf00da6.tar.gz php-shirabe-a73e44e327776ac4ba79737eea6b6ad00cf00da6.tar.zst php-shirabe-a73e44e327776ac4ba79737eea6b6ad00cf00da6.zip | |
fix(platform): match PHP truthy semantics for CI env checks
Platform::get_env("CI").is_some()/is_none() only checked whether the
variable was set, unlike PHP's (bool) Platform::getEnv('CI') which
treats "" and "0" as falsy. CI="0" (used by some CI providers to
explicitly disable CI mode) would previously flip behavior compared to
Composer.
Diffstat (limited to 'crates')
| -rw-r--r-- | crates/shirabe/src/installer/installation_manager.rs | 4 | ||||
| -rw-r--r-- | crates/shirabe/src/util/stream_context_factory.rs | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/crates/shirabe/src/installer/installation_manager.rs b/crates/shirabe/src/installer/installation_manager.rs index d89487c..04bff2a 100644 --- a/crates/shirabe/src/installer/installation_manager.rs +++ b/crates/shirabe/src/installer/installation_manager.rs @@ -488,7 +488,7 @@ impl InstallationManager { } if self.output_progress - && Platform::get_env("CI").is_none() + && !Platform::get_env("CI").is_some_and(|v| !v.is_empty() && v != "0") && !self.io.is_debug() && download_promise_count > 1 { @@ -747,7 +747,7 @@ impl InstallationManager { } if self.output_progress - && Platform::get_env("CI").is_none() + && !Platform::get_env("CI").is_some_and(|v| !v.is_empty() && v != "0") && !self.io.is_debug() && promise_count > 1 { diff --git a/crates/shirabe/src/util/stream_context_factory.rs b/crates/shirabe/src/util/stream_context_factory.rs index 6a40cd0..4335777 100644 --- a/crates/shirabe/src/util/stream_context_factory.rs +++ b/crates/shirabe/src/util/stream_context_factory.rs @@ -203,7 +203,7 @@ impl StreamContextFactory { .as_deref() .map(|v| format!("; Platform-PHP {}", v)) .unwrap_or_default(), - ci = if Platform::get_env("CI").is_some() { + ci = if Platform::get_env("CI").is_some_and(|v| !v.is_empty() && v != "0") { "; CI" } else { "" |