aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-21 21:25:15 +0900
committernsfisis <nsfisis@gmail.com>2026-06-22 00:49:03 +0900
commitf691b864b687f251c3b266e8cff2774d730567ba (patch)
tree86d361d44531240436fa6a55589acc206b9aae01 /crates
parent8db88c2da2cf387bc58843ac5093bb15b9fc3252 (diff)
downloadphp-shirabe-f691b864b687f251c3b266e8cff2774d730567ba.tar.gz
php-shirabe-f691b864b687f251c3b266e8cff2774d730567ba.tar.zst
php-shirabe-f691b864b687f251c3b266e8cff2774d730567ba.zip
test(php-shim): un-ignore tests now unblocked by implemented shims
Remove #[ignore] from tests gated solely on a shim function that is now implemented, where the test passes: - metapackage_installer::test_update (version_compare) - platform_requirement_filter_factory::test_from_bool_throws... (get_debug_type) - runtime::test_parse_extension_info (html_entity_decode/strip_tags) - package_sorter::test_sorting_does_nothing... (strnatcasecmp) - no_proxy_pattern::test_host_name/test_port (unpack/substr_count) - version_parser::test_is_upgrade (version_compare) - pool::test_what_provides_package_with_constraint - proxy_item::test_throws_on_malformed_url Update the ignore reason where the cited shim is now implemented but the test still cannot pass for a different reason: - no_proxy_pattern::test_ip_address/test_ip_range (IPv4-mapped IPv6 gap) - package_sorter::test_sorting_orders... (look-around regex) - proxy_item::test_url_formatting (parse_url host discrepancy) - json_manipulator/json_config_source/filesystem_repository stubs (test bodies are still todo!(), not yet ported) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates')
-rw-r--r--crates/shirabe/tests/config/json_config_source_test.rs18
-rw-r--r--crates/shirabe/tests/dependency_resolver/pool_test.rs1
-rw-r--r--crates/shirabe/tests/filter/platform_requirement_filter/platform_requirement_filter_factory_test.rs1
-rw-r--r--crates/shirabe/tests/installer/metapackage_installer_test.rs1
-rw-r--r--crates/shirabe/tests/json/json_manipulator_test.rs103
-rw-r--r--crates/shirabe/tests/package/version/version_parser_test.rs1
-rw-r--r--crates/shirabe/tests/platform/runtime_test.rs1
-rw-r--r--crates/shirabe/tests/repository/filesystem_repository_test.rs15
-rw-r--r--crates/shirabe/tests/util/http/proxy_item_test.rs3
-rw-r--r--crates/shirabe/tests/util/no_proxy_pattern_test.rs6
-rw-r--r--crates/shirabe/tests/util/package_sorter_test.rs3
11 files changed, 68 insertions, 85 deletions
diff --git a/crates/shirabe/tests/config/json_config_source_test.rs b/crates/shirabe/tests/config/json_config_source_test.rs
index 2d101aa..b8abf57 100644
--- a/crates/shirabe/tests/config/json_config_source_test.rs
+++ b/crates/shirabe/tests/config/json_config_source_test.rs
@@ -31,59 +31,57 @@ impl Drop for TearDown {
}
}
-// JsonConfigSource edits composer.json through JsonManipulator, whose text-rewriting
-// operations reach addcslashes (todo!()) in the php-shim.
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_as_list() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_with_options() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_repository() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_packagist_repository_with_false_value() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_packagist() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_link() {
let _tear_down = set_up();
todo!()
}
#[test]
-#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_link() {
let _tear_down = set_up();
todo!()
diff --git a/crates/shirabe/tests/dependency_resolver/pool_test.rs b/crates/shirabe/tests/dependency_resolver/pool_test.rs
index 68a7f2a..2814aa6 100644
--- a/crates/shirabe/tests/dependency_resolver/pool_test.rs
+++ b/crates/shirabe/tests/dependency_resolver/pool_test.rs
@@ -36,7 +36,6 @@ fn test_pool() {
}
#[test]
-#[ignore = "what_provides with a constraint reaches a todo!() in the php-shim"]
fn test_what_provides_package_with_constraint() {
let first_package = get_package("foo", "1");
let second_package = get_package("foo", "2");
diff --git a/crates/shirabe/tests/filter/platform_requirement_filter/platform_requirement_filter_factory_test.rs b/crates/shirabe/tests/filter/platform_requirement_filter/platform_requirement_filter_factory_test.rs
index ead80a3..10012e7 100644
--- a/crates/shirabe/tests/filter/platform_requirement_filter/platform_requirement_filter_factory_test.rs
+++ b/crates/shirabe/tests/filter/platform_requirement_filter/platform_requirement_filter_factory_test.rs
@@ -42,7 +42,6 @@ fn test_from_bool_or_list() {
}
#[test]
-#[ignore = "get_debug_type is todo!() in the php-shim (used to build the error message)"]
fn test_from_bool_throws_exception_if_type_is_unknown() {
let result = PlatformRequirementFilterFactory::from_bool_or_list(PhpMixed::Null);
let err = result.unwrap_err();
diff --git a/crates/shirabe/tests/installer/metapackage_installer_test.rs b/crates/shirabe/tests/installer/metapackage_installer_test.rs
index 60aac92..7766ed1 100644
--- a/crates/shirabe/tests/installer/metapackage_installer_test.rs
+++ b/crates/shirabe/tests/installer/metapackage_installer_test.rs
@@ -44,7 +44,6 @@ fn test_install() {
}
#[test]
-#[ignore = "MetapackageInstaller::update formats an UpdateOperation, which reaches version_compare (todo!()) in the php-shim"]
fn test_update() {
let initial = get_package("test/initial", "1.0.0");
let target = get_package("test/target", "1.0.1");
diff --git a/crates/shirabe/tests/json/json_manipulator_test.rs b/crates/shirabe/tests/json/json_manipulator_test.rs
index a3ede89..7cf8e87 100644
--- a/crates/shirabe/tests/json/json_manipulator_test.rs
+++ b/crates/shirabe/tests/json/json_manipulator_test.rs
@@ -1,304 +1,301 @@
//! ref: composer/tests/Composer/Test/Json/JsonManipulatorTest.php
-// JsonManipulator's text-rewriting operations reach addcslashes, which is todo!() in the
-// php-shim, so none of these cases can run yet.
-
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_link() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_link_and_sort_packages() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_sub_node() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_sub_node_from_require() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_sub_node_preserves_object_type_when_empty() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_sub_node_preserves_object_type_when_empty2() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_sub_node_in_require() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_extra_with_package() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_with_package() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_suggest_with_package() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_can_initialize_empty_repositories() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_can_initialize_from_scratch() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_can_append() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_can_prepend() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_can_override_deep_repos() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_set_url_in_repository() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_insert_repository_before_and_after_by_name() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_repository_removes_from_assoc_but_does_not_converts_from_assoc_to_list() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_repository_removes_from_list() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_repository_converts_from_assoc_to_list() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_escapes() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_works_from_scratch() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_add() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_overwrite() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_overwrite_numbers() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_overwrite_arrays() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_add_sub_key_in_empty_config() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_add_sub_key_in_empty_val() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_config_setting_can_add_sub_key_in_hash() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_root_setting_does_not_break_dots() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_config_setting_can_remove_sub_key_in_hash() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_config_setting_can_remove_sub_key_in_hash_with_siblings() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_main_key() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_main_key_with_content_having_dollar_sign_followed_by_digit() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_main_key_with_content_having_dollar_sign_followed_by_digit2() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_update_main_key() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_update_main_key2() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_update_main_key3() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_update_main_key_with_content_having_dollar_sign_followed_by_digit() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_main_key() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_main_key_if_empty() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_main_key_removes_key_where_value_is_null() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_indent_detection() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_main_key_at_end_of_file() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_add_list_item() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_remove_list_item() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_insert_list_item() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_escaped_unicode_does_not_cause_backtrack_limit_error_github_issue8131() {
todo!()
}
#[test]
-#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_large_file_does_not_cause_backtrack_limit_error_github_issue9595() {
todo!()
}
diff --git a/crates/shirabe/tests/package/version/version_parser_test.rs b/crates/shirabe/tests/package/version/version_parser_test.rs
index b2ce409..c403580 100644
--- a/crates/shirabe/tests/package/version/version_parser_test.rs
+++ b/crates/shirabe/tests/package/version/version_parser_test.rs
@@ -57,7 +57,6 @@ fn provide_parse_name_version_pairs_data() -> Vec<(Vec<String>, Vec<IndexMap<Str
}
#[test]
-#[ignore = "VersionParser::is_upgrade reaches a todo!() in the php-shim"]
fn test_is_upgrade() {
for (from, to, expected) in provide_is_upgrade_tests() {
assert_eq!(expected, VersionParser::is_upgrade(&from, &to).unwrap());
diff --git a/crates/shirabe/tests/platform/runtime_test.rs b/crates/shirabe/tests/platform/runtime_test.rs
index 4c58404..ebdeaff 100644
--- a/crates/shirabe/tests/platform/runtime_test.rs
+++ b/crates/shirabe/tests/platform/runtime_test.rs
@@ -3,7 +3,6 @@
use shirabe::platform::runtime::Runtime;
#[test]
-#[ignore = "Runtime::parse_html_extension_info reaches a todo!() in the php-shim (html_entity_decode)"]
fn test_parse_extension_info() {
for (html_input, expected_output) in provide_extension_infos() {
assert_eq!(
diff --git a/crates/shirabe/tests/repository/filesystem_repository_test.rs b/crates/shirabe/tests/repository/filesystem_repository_test.rs
index d798fc9..a14804b 100644
--- a/crates/shirabe/tests/repository/filesystem_repository_test.rs
+++ b/crates/shirabe/tests/repository/filesystem_repository_test.rs
@@ -1,40 +1,37 @@
//! ref: composer/tests/Composer/Test/Repository/FilesystemRepositoryTest.php
-// These read/write installed.json and installed.php fixtures via JsonFile and assert the
-// generated output; the file IO/manipulation (JsonManipulator reaches addcslashes, todo!())
-// and fixtures are not ported.
#[test]
-#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_repository_read() {
todo!()
}
#[test]
-#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_corrupted_repository_file() {
todo!()
}
#[test]
-#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_unexistent_repository_file() {
todo!()
}
#[test]
-#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_repository_write() {
todo!()
}
#[test]
-#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_repository_writes_installed_php() {
todo!()
}
#[test]
-#[ignore = "reads/writes installed.json/installed.php fixtures via JsonFile/JsonManipulator (addcslashes todo!())"]
+#[ignore = "test body not yet ported (todo!() stub)"]
fn test_safely_load_installed_versions() {
todo!()
}
diff --git a/crates/shirabe/tests/util/http/proxy_item_test.rs b/crates/shirabe/tests/util/http/proxy_item_test.rs
index 0607bd5..a8c0438 100644
--- a/crates/shirabe/tests/util/http/proxy_item_test.rs
+++ b/crates/shirabe/tests/util/http/proxy_item_test.rs
@@ -3,7 +3,6 @@
use shirabe::util::http::proxy_item::ProxyItem;
#[test]
-#[ignore = "ProxyItem::new reaches a todo!() in the php-shim"]
fn test_throws_on_malformed_url() {
for url in data_malformed() {
assert!(ProxyItem::new(url.to_string(), "http_proxy".to_string()).is_err());
@@ -30,7 +29,7 @@ fn data_malformed() -> Vec<&'static str> {
}
#[test]
-#[ignore = "ProxyItem::new reaches a todo!() in the php-shim"]
+#[ignore = "URL parsing yields no host for these cases, so proxy formatting fails (parse_url/port discrepancy)"]
fn test_url_formatting() {
for (url, expected) in data_formatting() {
let proxy_item = ProxyItem::new(url.to_string(), "http_proxy".to_string()).unwrap();
diff --git a/crates/shirabe/tests/util/no_proxy_pattern_test.rs b/crates/shirabe/tests/util/no_proxy_pattern_test.rs
index 8585eea..7a423b9 100644
--- a/crates/shirabe/tests/util/no_proxy_pattern_test.rs
+++ b/crates/shirabe/tests/util/no_proxy_pattern_test.rs
@@ -28,7 +28,6 @@ fn get_url(url: &str) -> String {
}
#[test]
-#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"]
fn test_host_name() {
let noproxy = "foobar.com, .barbaz.net";
@@ -43,7 +42,7 @@ fn test_host_name() {
}
#[test]
-#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"]
+#[ignore = "NoProxyPattern does not match IPv4-mapped IPv6 addresses against IPv4 rules (port logic gap)"]
fn test_ip_address() {
let noproxy = "192.168.1.1, 2001:db8::52:0:1";
@@ -56,7 +55,7 @@ fn test_ip_address() {
}
#[test]
-#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"]
+#[ignore = "NoProxyPattern does not match IPv4-mapped IPv6 addresses against IPv4/CIDR rules (port logic gap)"]
fn test_ip_range() {
let noproxy = "10.0.0.0/30, 2002:db8:a::45/121";
@@ -69,7 +68,6 @@ fn test_ip_range() {
}
#[test]
-#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"]
fn test_port() {
let noproxy = "192.168.1.2:81, 192.168.1.3:80, [2001:db8::52:0:2]:443, [2001:db8::52:0:3]:80";
diff --git a/crates/shirabe/tests/util/package_sorter_test.rs b/crates/shirabe/tests/util/package_sorter_test.rs
index 1b95824..f84ff09 100644
--- a/crates/shirabe/tests/util/package_sorter_test.rs
+++ b/crates/shirabe/tests/util/package_sorter_test.rs
@@ -32,7 +32,6 @@ fn names(packages: &[PackageInterfaceHandle]) -> Vec<String> {
}
#[test]
-#[ignore = "PackageSorter::sort_packages reaches strnatcasecmp, a todo!() in the php-shim"]
fn test_sorting_does_nothing_with_no_dependencies() {
let packages = vec![
create_package("foo/bar1", &[]),
@@ -142,7 +141,7 @@ fn sorting_orders_dependencies_higher_than_package_cases() -> Vec<(
}
#[test]
-#[ignore = "PackageSorter::sort_packages reaches strnatcasecmp, a todo!() in the php-shim"]
+#[ignore = "constraint parsing reaches a look-around regex unsupported by the regex-crate shim (Preg)"]
fn test_sorting_orders_dependencies_higher_than_package() {
for (packages, expected_ordered_list, weights) in
sorting_orders_dependencies_higher_than_package_cases()