aboutsummaryrefslogtreecommitdiffhomepage
path: root/scripts/linters/cargo_workspace_dependencies.rb
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-20 08:21:48 +0900
committernsfisis <nsfisis@gmail.com>2026-07-20 08:24:45 +0900
commit85fb9b70f4f41ead644b24f98052e6ffd9699e48 (patch)
treeede4348cf68b94af923c1c8c0dd668c7f0aac043 /scripts/linters/cargo_workspace_dependencies.rb
parent087865ef50283350a3cc74a5363ba44fa7dbe5c5 (diff)
downloadphp-shirabe-85fb9b70f4f41ead644b24f98052e6ffd9699e48.tar.gz
php-shirabe-85fb9b70f4f41ead644b24f98052e6ffd9699e48.tar.zst
php-shirabe-85fb9b70f4f41ead644b24f98052e6ffd9699e48.zip
fix(diagnose-command): stop holding a Config borrow across http calls
execute() held &config.borrow() across check_http/check_composer_repo/ check_composer_audit, which reach HttpDownloader -> CurlDownloader:: download; that method does self.config.borrow_mut() on the same Config RefCell, panicking with "RefCell already borrowed" once the phpinfo panic that previously masked this was fixed. Switch those three helpers to take the Rc<RefCell<Config>> handle (matching check_version's existing pattern) and borrow only where a field is actually read, so no borrow spans the downstream network call. Un-ignore the now-passing run_diagnose smoke test and test_cmd_fail; test_cmd_success stays ignored, now for two separate reasons: it needs real network access (as the PHP original does), and shirabe_php_shim::OPENSSL_VERSION_NUMBER is a hardcoded stub (0) that always trips check_platform's TLSv1.1/1.2 support check regardless of the real linked OpenSSL, forcing a non-zero exit code.
Diffstat (limited to 'scripts/linters/cargo_workspace_dependencies.rb')
0 files changed, 0 insertions, 0 deletions