aboutsummaryrefslogtreecommitdiffhomepage
path: root/scripts/linters/lint
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-25 23:25:46 +0900
committernsfisis <nsfisis@gmail.com>2026-07-25 23:25:46 +0900
commitf47b9ad7e108f29f657459569b2a41f5cdf0a74a (patch)
tree06b98991ceba2b058e07b416078fd76bfa8faf1f /scripts/linters/lint
parent3c39377b0c419dd4cc792aef926032b15c12b69f (diff)
downloadphp-shirabe-f47b9ad7e108f29f657459569b2a41f5cdf0a74a.tar.gz
php-shirabe-f47b9ad7e108f29f657459569b2a41f5cdf0a74a.tar.zst
php-shirabe-f47b9ad7e108f29f657459569b2a41f5cdf0a74a.zip
fix(require-command): end input borrow before asking for confirmation
The `fixed` option was read as a temporary inside the argument list of update_requirements_after_resolution(), so the Ref lived until the end of the enclosing let statement — i.e. across the whole call. When the resolved version looks like a feature branch, that call asks for confirmation, and ConsoleIO takes the same input RefCell mutably, panicking with "RefCell already borrowed". Hoisting the read into its own statement ends the borrow before the call. The expected output of the un-ignored test transcribed PHP's string concatenation operator (`[y,n]? '.'`, used to keep the trailing space visible) as a literal `.`; it now matches RequireCommandTest.php. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'scripts/linters/lint')
0 files changed, 0 insertions, 0 deletions