diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-18 15:03:55 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-18 15:54:27 +0900 |
| commit | 91692846909ed191addb7ec1c34aad11392ab88b (patch) | |
| tree | 7c477055e432fd43a98e5dddc016e07dcfc67f60 /scripts | |
| parent | 4ae58baf8618f5fe916ba2a69faaca93514134ce (diff) | |
| download | php-shirabe-91692846909ed191addb7ec1c34aad11392ab88b.tar.gz php-shirabe-91692846909ed191addb7ec1c34aad11392ab88b.tar.zst php-shirabe-91692846909ed191addb7ec1c34aad11392ab88b.zip | |
perf(regex): eliminate per-call clone overhead in preg_* dispatch
regex::Regex::clone() does not share the underlying meta engine's
search-cache pool, so every fresh clone pays a ~10us warmup cost on
its first use. Two changes together eliminate this across nearly all
preg_* call sites:
- A php_regex! macro resolves PHP-style patterns to a per-call-site
&'static regex::Regex (via regex-macro's LazyLock), applied at the
majority of call sites throughout the codebase.
- Call sites still passing dynamic pattern strings go through
PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out
Arc::clone()s instead of cloning the Regex itself.
PregPattern::resolve() returns a ResolvedPattern enum (Arc or
'static reference) rather than an owned Regex, so neither path ever
clones the Regex proper.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/bench/create-project.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/bench/create-project.sh b/scripts/bench/create-project.sh index 4f52732b..87852ef9 100755 --- a/scripts/bench/create-project.sh +++ b/scripts/bench/create-project.sh @@ -33,8 +33,8 @@ hyperfine \ --export-json "$OUTDIR/results-$PACKAGE_SLUG.json" \ --export-markdown "$OUTDIR/results-$PACKAGE_SLUG.md" \ --ignore-failure \ - "'$BIN' create-project --profile --no-plugins --no-scripts '$PACKAGE' '$TARGET_DIR-shirabe'" \ - "composer create-project --profile --no-plugins --no-scripts '$PACKAGE' '$TARGET_DIR-composer'" + --command-name Shirabe "'$BIN' create-project --profile --no-plugins --no-scripts '$PACKAGE' '$TARGET_DIR-shirabe'" \ + --command-name Composer "composer create-project --profile --no-plugins --no-scripts '$PACKAGE' '$TARGET_DIR-composer'" echo ">> results: $OUTDIR/results-$PACKAGE_SLUG.json" >&2 echo ">> $OUTDIR/results-$PACKAGE_SLUG.md" >&2 |