aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs
diff options
context:
space:
mode:
Diffstat (limited to 'crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs')
-rw-r--r--crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs14
1 files changed, 10 insertions, 4 deletions
diff --git a/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs b/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs
index 01f8eb78..3bbe9014 100644
--- a/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs
+++ b/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs
@@ -19,10 +19,16 @@ impl XdebugHandler {
pub fn get_all_ini_files() -> Vec<String> {
// TODO(php-runtime)
- // No XdebugHandler is ever constructed (`self::$name` stays null) so the
- // COMPOSER_ORIG_INIS env lookup is skipped, and without a PHP runtime
- // `php_ini_loaded_file()` is `false` and `php_ini_scanned_files()` is `false`,
- // so PHP would return `[(string) false]` = `[""]`.
+ // No XdebugHandler is ever constructed (`self::$name` stays null), because the
+ // `new XdebugHandler('Composer'); $xdebug->check();` bootstrap in `bin/composer` is not
+ // ported (see the TODO(phase-c) at the top of shirabe's main.rs), so the
+ // COMPOSER_ORIGINAL_INIS env-var branch is unreachable here.
+ //
+ // shirabe-external-packages cannot depend on shirabe-php-rpc (the reverse dependency
+ // would cycle, since shirabe-php-rpc already depends on shirabe-external-packages), so
+ // callers that need the real PHP runtime's ini files (php_ini_loaded_file() /
+ // php_ini_scanned_files()) query shirabe_php_rpc directly instead of going through this
+ // stub; see crate::util::ini_helper::IniHelper::get_all.
vec![String::new()]
}
}