aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/console/command/command.rs
diff options
context:
space:
mode:
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/command/command.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/console/command/command.rs8
1 files changed, 5 insertions, 3 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/command/command.rs b/crates/shirabe-external-packages/src/symfony/console/command/command.rs
index 2d94ad2..59aa915 100644
--- a/crates/shirabe-external-packages/src/symfony/console/command/command.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/command/command.rs
@@ -822,9 +822,11 @@ impl Command for CommandData {
Some(helper_set) => helper_set,
};
- // TODO(review): HelperSet::get() returns `Rc<RefCell<dyn HelperInterface>>`, but
- // Command::getHelper() is typed `mixed` (PhpMixed) here and PhpMixed cannot hold a
- // helper instance. The helper return modelling needs a dedicated type (Phase C).
+ // TODO(plugin): PHP's Command::getHelper($name) looks a helper up by string via
+ // HelperSet::get($name). The HelperSet is now a closed set exposing only typed getters
+ // (get_formatter/get_question/...), so a string-keyed lookup no longer exists. Callers
+ // should use the typed getters on the HelperSet directly; restoring name-based lookup is
+ // deferred until the plugin API (which is the only source of dynamically named helpers).
let _ = helper_set;
todo!()
}