aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/process/pipes
diff options
context:
space:
mode:
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/process/pipes')
-rw-r--r--crates/shirabe-external-packages/src/symfony/process/pipes/abstract_pipes.rs9
-rw-r--r--crates/shirabe-external-packages/src/symfony/process/pipes/unix_pipes.rs9
2 files changed, 8 insertions, 10 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/process/pipes/abstract_pipes.rs b/crates/shirabe-external-packages/src/symfony/process/pipes/abstract_pipes.rs
index 47db6b9..d8ced43 100644
--- a/crates/shirabe-external-packages/src/symfony/process/pipes/abstract_pipes.rs
+++ b/crates/shirabe-external-packages/src/symfony/process/pipes/abstract_pipes.rs
@@ -37,13 +37,8 @@ impl AbstractPipes {
}
pub fn close(&mut self) {
- if let PhpMixed::List(pipes) = &self.pipes {
- for pipe in pipes {
- if php::is_resource(pipe) {
- php::fclose(pipe.clone());
- }
- }
- }
+ // TODO(phase-d): each pipe is a PHP stream resource that should be fclose()d, but the pipe
+ // list is a PhpMixed that cannot hold a PhpResource; the handles are dropped instead.
self.pipes = PhpMixed::List(Vec::new());
}
diff --git a/crates/shirabe-external-packages/src/symfony/process/pipes/unix_pipes.rs b/crates/shirabe-external-packages/src/symfony/process/pipes/unix_pipes.rs
index 387bcdf..983ed07 100644
--- a/crates/shirabe-external-packages/src/symfony/process/pipes/unix_pipes.rs
+++ b/crates/shirabe-external-packages/src/symfony/process/pipes/unix_pipes.rs
@@ -44,9 +44,12 @@ fn descriptor(items: &[&str]) -> PhpMixed {
impl PipesInterface for UnixPipes {
fn get_descriptors(&mut self) -> Vec<PhpMixed> {
if !self.have_read_support {
- let nullstream = shirabe_php_shim::fopen("/dev/null", "c");
-
- return vec![descriptor(&["pipe", "r"]), nullstream.clone(), nullstream];
+ // TODO(phase-d): /dev/null is opened as a stream resource and placed directly into the
+ // proc_open descriptor spec, but the descriptor list is a Vec<PhpMixed> that cannot
+ // carry a PhpResource.
+ todo!(
+ "UnixPipes::get_descriptors: the /dev/null resource cannot be represented in a PhpMixed descriptor list"
+ );
}
if self.tty_mode == Some(true) {