diff options
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony')
4 files changed, 8 insertions, 8 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/command/command.rs b/crates/shirabe-external-packages/src/symfony/console/command/command.rs index f9808878..88c1839b 100644 --- a/crates/shirabe-external-packages/src/symfony/console/command/command.rs +++ b/crates/shirabe-external-packages/src/symfony/console/command/command.rs @@ -63,8 +63,8 @@ impl CommandData { pub fn get_default_name() -> Option<String> { // TODO(phase-c): PHP uses ReflectionClass to read the #[AsCommand] attribute // and ReflectionProperty to check that `$defaultName` is declared on the late-static - // class itself (not inherited). Reflection-based late static binding cannot be - // reproduced in Phase A; human review needed for the porting strategy. + // class itself (not inherited). Reflection-based late static binding has no direct + // Rust equivalent; human review needed for the porting strategy. todo!() } diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs index 42c920f6..66ab3174 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs @@ -999,8 +999,8 @@ impl Table { } // PHP returns a TableRows wrapping a generator that lazily yields row groups. - // The generator borrows $this to call fillCells(). In Phase A we precompute the - // row groups eagerly to preserve behavior, then hand them to TableRows. + // The generator borrows $this to call fillCells(). Here the row groups are + // precomputed eagerly to preserve behavior, then handed to TableRows. let mut row_groups: Vec<Vec<Row>> = Vec::new(); for (row_key, row) in rows.into_iter().enumerate() { let row_key = row_key as i64; diff --git a/crates/shirabe-external-packages/src/symfony/console/style/symfony_style.rs b/crates/shirabe-external-packages/src/symfony/console/style/symfony_style.rs index 0cc7cf25..9097faff 100644 --- a/crates/shirabe-external-packages/src/symfony/console/style/symfony_style.rs +++ b/crates/shirabe-external-packages/src/symfony/console/style/symfony_style.rs @@ -235,8 +235,8 @@ impl SymfonyStyle { .unwrap() .ask(&mut *input, self.output.clone(), question) }; - // PHP `askQuestion` returns the answer directly; exceptions propagate. Phase B - // collapses the double `Result` by panicking on either error. + // PHP `askQuestion` returns the answer directly; exceptions propagate. The double + // `Result` is collapsed here by panicking on either error. let answer = answer .expect("question helper error") .expect("missing input"); diff --git a/crates/shirabe-external-packages/src/symfony/filesystem/filesystem.rs b/crates/shirabe-external-packages/src/symfony/filesystem/filesystem.rs index 3759f499..071ee468 100644 --- a/crates/shirabe-external-packages/src/symfony/filesystem/filesystem.rs +++ b/crates/shirabe-external-packages/src/symfony/filesystem/filesystem.rs @@ -298,8 +298,8 @@ impl Filesystem { // TODO(phase-c): this only ports Symfony's readlink($path, $canonicalize = false) overload; // the $canonicalize = true branch (realpath()-based resolution, returning null if the path - // does not exist at all) is entirely unported. Per the phase B default-argument convention - // this should become a `read_link2` overload if that branch is ever needed. + // does not exist at all) is entirely unported. Following the numbered-suffix convention + // for PHP default arguments, it should become a `read_link2` overload if ever needed. fn read_link(&self, path: &str) -> String { // Symfony's readlink() with $canonicalize = false: returns null if the path is not a link. // TODO(phase-c): the Rust signature is non-Option, so the non-link case yields the path's |