diff options
Diffstat (limited to 'crates/shirabe/src/downloader/vcs_downloader.rs')
| -rw-r--r-- | crates/shirabe/src/downloader/vcs_downloader.rs | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/crates/shirabe/src/downloader/vcs_downloader.rs b/crates/shirabe/src/downloader/vcs_downloader.rs index b09841e..c3a1611 100644 --- a/crates/shirabe/src/downloader/vcs_downloader.rs +++ b/crates/shirabe/src/downloader/vcs_downloader.rs @@ -149,8 +149,9 @@ pub trait VcsDownloader: match attempt { Ok(promise) => return Ok(promise), Err(e) => { - // rethrow phpunit exceptions to avoid hard to debug bug failures - // TODO(phase-b): downcast to PHPUnit\Framework\Exception + // rethrow phpunit exceptions to avoid hard to debug bug failures. + // PHPUnit\Framework\Exception is out of scope (the test framework is not + // ported), so this instanceof check is always false. let is_phpunit_exception = false; if is_phpunit_exception { return Err(e); @@ -265,8 +266,9 @@ pub trait VcsDownloader: match attempt { Ok(_) => break, Err(e) => { - // rethrow phpunit exceptions to avoid hard to debug bug failures - // TODO(phase-b): downcast to PHPUnit\Framework\Exception + // rethrow phpunit exceptions to avoid hard to debug bug failures. + // PHPUnit\Framework\Exception is out of scope (the test framework is not + // ported), so this instanceof check is always false. let is_phpunit_exception = false; if is_phpunit_exception { return Err(e); @@ -344,8 +346,9 @@ pub trait VcsDownloader: break; } Err(e) => { - // rethrow phpunit exceptions to avoid hard to debug bug failures - // TODO(phase-b): downcast to PHPUnit\Framework\Exception + // rethrow phpunit exceptions to avoid hard to debug bug failures. + // PHPUnit\Framework\Exception is out of scope (the test framework is not + // ported), so this instanceof check is always false. let is_phpunit_exception = false; if is_phpunit_exception { return Err(e); |