diff options
Diffstat (limited to 'crates/shirabe/src/filter')
2 files changed, 7 insertions, 10 deletions
diff --git a/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_factory.rs b/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_factory.rs index 35a3ed9..a260c29 100644 --- a/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_factory.rs +++ b/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_factory.rs @@ -8,13 +8,14 @@ use crate::filter::platform_requirement_filter::{ }; use anyhow::Result; use shirabe_php_shim::{InvalidArgumentException, PhpMixed}; +use std::rc::Rc; pub struct PlatformRequirementFilterFactory; impl PlatformRequirementFilterFactory { pub fn from_bool_or_list( bool_or_list: PhpMixed, - ) -> Result<Box<dyn PlatformRequirementFilterInterface>> { + ) -> Result<Rc<dyn PlatformRequirementFilterInterface>> { match bool_or_list { PhpMixed::Bool(b) => { if b { @@ -35,7 +36,7 @@ impl PlatformRequirementFilterFactory { .collect(), _ => unreachable!(), }; - Ok(Box::new(IgnoreListPlatformRequirementFilter::new(list)?)) + Ok(Rc::new(IgnoreListPlatformRequirementFilter::new(list)?)) } other => Err(anyhow::anyhow!(InvalidArgumentException { message: format!( @@ -47,11 +48,11 @@ impl PlatformRequirementFilterFactory { } } - pub fn ignore_all() -> Box<dyn PlatformRequirementFilterInterface> { - Box::new(IgnoreAllPlatformRequirementFilter) + pub fn ignore_all() -> Rc<dyn PlatformRequirementFilterInterface> { + Rc::new(IgnoreAllPlatformRequirementFilter) } - pub fn ignore_nothing() -> Box<dyn PlatformRequirementFilterInterface> { - Box::new(IgnoreNothingPlatformRequirementFilter) + pub fn ignore_nothing() -> Rc<dyn PlatformRequirementFilterInterface> { + Rc::new(IgnoreNothingPlatformRequirementFilter) } } diff --git a/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_interface.rs b/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_interface.rs index 8061e1a..4ec528e 100644 --- a/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_interface.rs +++ b/crates/shirabe/src/filter/platform_requirement_filter/platform_requirement_filter_interface.rs @@ -6,8 +6,4 @@ pub trait PlatformRequirementFilterInterface: std::fmt::Debug { fn is_upper_bound_ignored(&self, req: &str) -> bool; fn as_any(&self) -> &dyn std::any::Any; - - fn clone_box(&self) -> Box<dyn PlatformRequirementFilterInterface> { - todo!() - } } |
