diff options
Diffstat (limited to 'crates/shirabe/src/package/version')
4 files changed, 7 insertions, 7 deletions
diff --git a/crates/shirabe/src/package/version/version_bumper.rs b/crates/shirabe/src/package/version/version_bumper.rs index e1f58942..cd52e9a4 100644 --- a/crates/shirabe/src/package/version/version_bumper.rs +++ b/crates/shirabe/src/package/version/version_bumper.rs @@ -26,11 +26,11 @@ impl VersionBumper { return Ok(pretty_constraint); } - let mut version = package.get_version().to_string(); + let mut version = package.get_version(); if version.starts_with("dev-") { let loader = ArrayLoader::new(Some(parser.clone()), false); let dumper = ArrayDumper::new(); - let dumped = dumper.dump(package.clone()); + let dumped = dumper.dump(package); let extra = loader.get_branch_alias(&dumped)?; if extra.is_none() || extra.as_deref() == Some(VersionParser::DEFAULT_BRANCH_ALIAS) { diff --git a/crates/shirabe/src/package/version/version_guesser.rs b/crates/shirabe/src/package/version/version_guesser.rs index 2f98e339..d7dc42eb 100644 --- a/crates/shirabe/src/package/version/version_guesser.rs +++ b/crates/shirabe/src/package/version/version_guesser.rs @@ -414,7 +414,7 @@ impl VersionGuesser { if VersionParser::DEFAULT_BRANCH_ALIAS == version { return Ok(Some(VersionData { - version: Some(version.clone()), + version: Some(version), commit: None, pretty_version: Some(format!("dev-{}", branch)), feature_version: None, diff --git a/crates/shirabe/src/package/version/version_parser.rs b/crates/shirabe/src/package/version/version_parser.rs index 8cf3aa72..4aecc834 100644 --- a/crates/shirabe/src/package/version/version_parser.rs +++ b/crates/shirabe/src/package/version/version_parser.rs @@ -130,7 +130,7 @@ impl VersionParser { return Ok(true); } - let sorted = Semver::sort(vec![normalized_to.clone(), normalized_from.clone()])?; + let sorted = Semver::sort(vec![normalized_to, normalized_from.clone()])?; Ok(sorted[0] == normalized_from) } diff --git a/crates/shirabe/src/package/version/version_selector.rs b/crates/shirabe/src/package/version/version_selector.rs index e8539212..bf5514a5 100644 --- a/crates/shirabe/src/package/version/version_selector.rs +++ b/crates/shirabe/src/package/version/version_selector.rs @@ -98,7 +98,7 @@ impl VersionSelector { }; let mut candidates = self.repository_set.borrow().find_packages( &strtolower(package_name), - constraint.clone(), + constraint, repo_set_flags, )?; @@ -273,7 +273,7 @@ impl VersionSelector { } } - let version = package.get_version().to_string(); + let version = package.get_version(); if !package.is_dev() { return self.transform_version( &version, @@ -299,7 +299,7 @@ impl VersionSelector { } } - Ok(package.get_pretty_version().to_string()) + Ok(package.get_pretty_version()) } fn transform_version( |