diff options
Diffstat (limited to 'crates/shirabe/src')
| -rw-r--r-- | crates/shirabe/src/command/package_discovery_trait.rs | 2 | ||||
| -rw-r--r-- | crates/shirabe/src/util/bitbucket.rs | 6 |
2 files changed, 3 insertions, 5 deletions
diff --git a/crates/shirabe/src/command/package_discovery_trait.rs b/crates/shirabe/src/command/package_discovery_trait.rs index 475b67db..e5427514 100644 --- a/crates/shirabe/src/command/package_discovery_trait.rs +++ b/crates/shirabe/src/command/package_discovery_trait.rs @@ -29,8 +29,6 @@ use shirabe_php_shim::{ /// @internal pub trait PackageDiscoveryTrait: BaseCommand { - // PHP: private $repos; private $repositorySets; - // TODO(phase-b): trait fields require an associated state struct in Rust; expose via accessors fn get_repos_mut( &self, ) -> std::cell::RefMut<'_, Option<crate::repository::RepositoryInterfaceHandle>>; diff --git a/crates/shirabe/src/util/bitbucket.rs b/crates/shirabe/src/util/bitbucket.rs index bba16e83..50d4b700 100644 --- a/crates/shirabe/src/util/bitbucket.rs +++ b/crates/shirabe/src/util/bitbucket.rs @@ -292,7 +292,7 @@ impl Bitbucket { return Ok(false); } - // TODO(phase-b): PHP $authConfigSource parameter is unused inside storeInAuthConfig + // NOTE: PHP $authConfigSource parameter is unused inside storeInAuthConfig // (upstream Composer bug); the dispatch on local vs. global is dropped here too. let _ = store_in_local_auth_config; self.store_in_auth_config(origin_url, &consumer_key, &consumer_secret)?; @@ -337,7 +337,7 @@ impl Bitbucket { return Ok(String::new()); } - // TODO(phase-b): PHP $authConfigSource parameter is unused inside storeInAuthConfig + // NOTE: PHP $authConfigSource parameter is unused inside storeInAuthConfig // (upstream Composer bug); the dispatch on local vs. global is dropped here too. self.store_in_auth_config(origin_url, consumer_key, consumer_secret)?; @@ -358,7 +358,7 @@ impl Bitbucket { } } - // TODO(phase-b): PHP $authConfigSource parameter dropped — unused in upstream Composer too. + // NOTE: PHP $authConfigSource parameter dropped — unused in upstream Composer too. fn store_in_auth_config( &mut self, origin_url: &str, |