diff options
Diffstat (limited to 'crates/shirabe/tests/util')
| -rw-r--r-- | crates/shirabe/tests/util/http/proxy_item_test.rs | 3 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/no_proxy_pattern_test.rs | 6 | ||||
| -rw-r--r-- | crates/shirabe/tests/util/package_sorter_test.rs | 3 |
3 files changed, 4 insertions, 8 deletions
diff --git a/crates/shirabe/tests/util/http/proxy_item_test.rs b/crates/shirabe/tests/util/http/proxy_item_test.rs index 0607bd5..a8c0438 100644 --- a/crates/shirabe/tests/util/http/proxy_item_test.rs +++ b/crates/shirabe/tests/util/http/proxy_item_test.rs @@ -3,7 +3,6 @@ use shirabe::util::http::proxy_item::ProxyItem; #[test] -#[ignore = "ProxyItem::new reaches a todo!() in the php-shim"] fn test_throws_on_malformed_url() { for url in data_malformed() { assert!(ProxyItem::new(url.to_string(), "http_proxy".to_string()).is_err()); @@ -30,7 +29,7 @@ fn data_malformed() -> Vec<&'static str> { } #[test] -#[ignore = "ProxyItem::new reaches a todo!() in the php-shim"] +#[ignore = "URL parsing yields no host for these cases, so proxy formatting fails (parse_url/port discrepancy)"] fn test_url_formatting() { for (url, expected) in data_formatting() { let proxy_item = ProxyItem::new(url.to_string(), "http_proxy".to_string()).unwrap(); diff --git a/crates/shirabe/tests/util/no_proxy_pattern_test.rs b/crates/shirabe/tests/util/no_proxy_pattern_test.rs index 8585eea..7a423b9 100644 --- a/crates/shirabe/tests/util/no_proxy_pattern_test.rs +++ b/crates/shirabe/tests/util/no_proxy_pattern_test.rs @@ -28,7 +28,6 @@ fn get_url(url: &str) -> String { } #[test] -#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"] fn test_host_name() { let noproxy = "foobar.com, .barbaz.net"; @@ -43,7 +42,7 @@ fn test_host_name() { } #[test] -#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"] +#[ignore = "NoProxyPattern does not match IPv4-mapped IPv6 addresses against IPv4 rules (port logic gap)"] fn test_ip_address() { let noproxy = "192.168.1.1, 2001:db8::52:0:1"; @@ -56,7 +55,7 @@ fn test_ip_address() { } #[test] -#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"] +#[ignore = "NoProxyPattern does not match IPv4-mapped IPv6 addresses against IPv4/CIDR rules (port logic gap)"] fn test_ip_range() { let noproxy = "10.0.0.0/30, 2002:db8:a::45/121"; @@ -69,7 +68,6 @@ fn test_ip_range() { } #[test] -#[ignore = "NoProxyPattern::test reaches a todo!() (substr_count) in the php-shim"] fn test_port() { let noproxy = "192.168.1.2:81, 192.168.1.3:80, [2001:db8::52:0:2]:443, [2001:db8::52:0:3]:80"; diff --git a/crates/shirabe/tests/util/package_sorter_test.rs b/crates/shirabe/tests/util/package_sorter_test.rs index 1b95824..f84ff09 100644 --- a/crates/shirabe/tests/util/package_sorter_test.rs +++ b/crates/shirabe/tests/util/package_sorter_test.rs @@ -32,7 +32,6 @@ fn names(packages: &[PackageInterfaceHandle]) -> Vec<String> { } #[test] -#[ignore = "PackageSorter::sort_packages reaches strnatcasecmp, a todo!() in the php-shim"] fn test_sorting_does_nothing_with_no_dependencies() { let packages = vec![ create_package("foo/bar1", &[]), @@ -142,7 +141,7 @@ fn sorting_orders_dependencies_higher_than_package_cases() -> Vec<( } #[test] -#[ignore = "PackageSorter::sort_packages reaches strnatcasecmp, a todo!() in the php-shim"] +#[ignore = "constraint parsing reaches a look-around regex unsupported by the regex-crate shim (Preg)"] fn test_sorting_orders_dependencies_higher_than_package() { for (packages, expected_ordered_list, weights) in sorting_orders_dependencies_higher_than_package_cases() |
