diff options
Diffstat (limited to 'crates/shirabe/tests')
| -rw-r--r-- | crates/shirabe/tests/command/require_command_test.rs | 16 | ||||
| -rw-r--r-- | crates/shirabe/tests/repository/platform_repository_test.rs | 24 |
2 files changed, 16 insertions, 24 deletions
diff --git a/crates/shirabe/tests/command/require_command_test.rs b/crates/shirabe/tests/command/require_command_test.rs index 2464f3d..e618650 100644 --- a/crates/shirabe/tests/command/require_command_test.rs +++ b/crates/shirabe/tests/command/require_command_test.rs @@ -17,7 +17,6 @@ fn input(pairs: Vec<(&str, PhpMixed)>) -> Vec<(PhpMixed, PhpMixed)> { #[test] #[serial] -#[ignore = "shirabe_php_shim::phpversion(extension) is a todo!() (per-extension version strings not modeled); reached while checking the ext-foobar platform requirement during version selection"] fn test_require_throws_if_none_matches() { let composer_json = serde_json::json!({ "repositories": { @@ -59,7 +58,10 @@ fn test_require_throws_if_none_matches() { #[test] #[serial] -#[ignore = "Phase-C re-entrancy: EventDispatcher::make_autoloader calls Composer borrow_mut while the Composer is already borrowed up the installer-event-dispatch stack, panicking with \"RefCell already borrowed\" (composer.rs:507)"] +#[ignore = "the prior RefCell re-entrancy panic is fixed; now fails on the pre-operations-exec \ + listener dispatch with \"Subscriber ?::? for event pre-operations-exec is not \ + callable\" (event_dispatcher.rs TODO(plugin): is_callable/invoke for non-string \ + callables is unimplemented)"] fn test_require_warns_if_resolved_to_feature_branch() { let composer_json = serde_json::json!({ "repositories": { @@ -264,7 +266,10 @@ Using version 1.1.0 for required/pkg", #[test] #[serial] -#[ignore = "Phase-C re-entrancy: EventDispatcher::make_autoloader calls Composer borrow_mut while the Composer is already borrowed up the installer-event-dispatch stack, panicking with \"RefCell already borrowed\" (composer.rs:507)"] +#[ignore = "the prior RefCell re-entrancy panic is fixed; now fails on the pre-operations-exec \ + listener dispatch with \"Subscriber ?::? for event pre-operations-exec is not \ + callable\" (event_dispatcher.rs TODO(plugin): is_callable/invoke for non-string \ + callables is unimplemented)"] fn test_require() { for (label, composer_json, command, expected) in provide_require() { let _tear_down = init_temp_composer(Some(&composer_json), None, None, true); @@ -335,7 +340,10 @@ fn provide_inconsistent_require_keys() -> Vec<(bool, bool, &'static str)> { #[test] #[serial] -#[ignore = "update/solver pipeline incomplete: the require run fails with \"Fixed package __root__ 1.0.0+no-version-set was not added to solver pool.\" (the root package is not seeded into the solver pool)"] +#[ignore = "the solver-pool root-package issue is fixed; now panics in shirabe_php_shim::preg \ + (\"look-around, including look-ahead and look-behind, is not supported\") because \ + the dev-branch pattern `^dev-(?!main$|master$|trunk$|latest$)` uses a lookahead the \ + `regex` crate cannot express (see docs/dev/regex-porting.md)"] fn test_inconsistent_require_keys() { for (is_dev, is_interactive, expected_warning) in provide_inconsistent_require_keys() { let current_key = if is_dev { "require" } else { "require-dev" }; diff --git a/crates/shirabe/tests/repository/platform_repository_test.rs b/crates/shirabe/tests/repository/platform_repository_test.rs index 7d2a328..83edf63 100644 --- a/crates/shirabe/tests/repository/platform_repository_test.rs +++ b/crates/shirabe/tests/repository/platform_repository_test.rs @@ -55,17 +55,7 @@ fn constant_key(constant_name: &str, class: Option<&str>) -> String { .to_string() } -// All five tests below are fully ported but kept `#[ignore]`: every code path through -// `PlatformRepository::initialize()` reaches `XdebugHandler::get_skipped_version()`, -// which is an unrelated `todo!()` stub in `shirabe-external-packages`, so the tests -// panic before any assertion (Phase D: visible failure is acceptable, and the category -// brief permits leaving confidently-panicking tests ignored). The seam/mocks are in -// place so they will execute once that stub lands. - #[test] -#[ignore = "seam + HhvmDetector mock ported; execution panics at the unrelated \ - XdebugHandler::get_skipped_version() todo!() during initialize(), and the \ - default (real) Runtime also relies on PHP-runtime shim todo!()s"] fn test_hhvm_package() { let mut hhvm_detector = MockHhvmDetector::new(); hhvm_detector @@ -145,8 +135,6 @@ fn php_flavor_test_cases() -> Vec<( } #[test] -#[ignore = "seam + Runtime mock ported (hasConstant/getConstant/invoke/getExtensions); \ - execution panics at the unrelated XdebugHandler::get_skipped_version() todo!()"] fn test_php_version() { for (constants, packages, functions) in php_flavor_test_cases() { let constants_has = constants.clone(); @@ -209,8 +197,6 @@ fn test_php_version() { } #[test] -#[ignore = "seam + Runtime mock ported (invoke once + getConstant callback); \ - execution panics at the unrelated XdebugHandler::get_skipped_version() todo!()"] fn test_inet_pton_regression() { let mut runtime = MockRuntime::new(); // PHP: ->expects(self::once())->method('invoke')->with('inet_pton', ['::'])->willReturn(false). @@ -1627,10 +1613,10 @@ fn assert_package_links( } #[test] -#[ignore = "all 59 provideLibraryTestCases datasets ported faithfully; execution still \ - panics at the unrelated XdebugHandler::get_skipped_version() todo!() (and a few \ - cases additionally rely on the ResourceBundle/Imagick stub paths), so it stays \ - ignored"] +#[ignore = "all 59 provideLibraryTestCases datasets ported faithfully; several cases rely on \ + ResourceBundle/Imagick-derived extension info (e.g. lib-icu-cldr) that is not yet \ + modeled, so the generated package set diverges from PHP's (confirmed: fails with \ + an extension mismatch, not a panic), and it stays ignored"] fn test_library_information() { let extension_version = "100.200.300"; @@ -1803,8 +1789,6 @@ fn test_library_information() { } #[test] -#[ignore = "seam + Runtime mock ported (getConstant/getExtensions map); execution panics \ - at the unrelated XdebugHandler::get_skipped_version() todo!()"] fn test_composer_platform_version() { let constants: IndexMap<String, PhpMixed> = IndexMap::from([ ( |