diff options
Diffstat (limited to 'crates')
7 files changed, 472 insertions, 114 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/finder/glob.rs b/crates/shirabe-external-packages/src/symfony/finder/glob.rs index fe5398fb..247b772f 100644 --- a/crates/shirabe-external-packages/src/symfony/finder/glob.rs +++ b/crates/shirabe-external-packages/src/symfony/finder/glob.rs @@ -1,108 +1,466 @@ //! ref: composer/vendor/symfony/finder/Glob.php +// Regex pattern compatibility: +// PHP's Glob::toRegex builds its regex in a single character loop and emits PCRE-only +// constructs: the look-ahead `(?=[^\.])` enforcing the strict-leading-dot rule, and a +// possessive `[^/]++` inside the `/**/` construct. The regex crate supports neither, so +// instead of a verbatim port of the loop, the glob is first tokenized (mirroring the +// loop's dispatch exactly) and every no-dot constraint is then resolved by recursive +// union expansion, producing a regex-crate-compatible pattern that matches the same +// inputs: +// +// (?=[^.])c => c (branch is unmatchable when c is `\.`) +// (?=[^.])[^/] => [^/.] +// (?=[^.])[abc] => [[abc]&&[^.]] (character class intersection) +// (?=[^.])[^/]*R => (?:[^/.][^/]*R | expand((?=[^.])R)) +// (?=[^.])(a|b)R => (?:expand((?=[^.])aR) | expand((?=[^.])bR)) +// (?=[^.])$ => branch dropped (no next character can exist) +// (?=[^.])(?:$|/) => / (dir-boundary variant only) +// [^/]++ => [^/]+ (the regex crate never backtracks) +// +// Unmatchable branches are dropped; a wholly unmatchable glob renders as `\b\B`, which +// compiles and never matches, just like PHP's own output for such globs. + #[derive(Debug)] pub struct Glob; +#[derive(Debug, Clone, Copy)] +struct Ctx { + strict_leading_dot: bool, + strict_wildcard_slash: bool, +} + +#[derive(Debug, Clone, Copy)] +enum Terminal { + /// The `$` anchor of `to_regex` follows the body. + EndAnchor, + /// The `(?:$|/)` suffix of `to_regex_dir_boundary` ends the body. + EndOrSlash, +} + +#[derive(Debug, Clone)] +enum Token { + /// A literal regex piece for one glob character, escaped as needed. + Text(String), + /// An unescaped `*`. + Star, + /// An unescaped `?`. + Question, + /// A `/**/` (or trailing `/**`) segment, leading slash included. + Globstar { trailing_slash_optional: bool }, + /// An `{a,b}` alternation. `closed` is false when the `}` is missing. + Group { + alternatives: Vec<Vec<Token>>, + closed: bool, + }, + /// The position of PHP's `(?=[^\.])` look-ahead. + NoDot, + /// End of the pattern. + End(Terminal), +} + +#[derive(Debug)] +enum Out { + /// Fully rendered. + Ok(String), + /// Cannot match anything; the branch must be dropped. + Dead, + /// A no-dot constraint reached the end of an isolated sub-sequence (e.g. `{a/,b}` + /// puts a look-ahead right before the closing brace); the caller must splice in the + /// following context and re-render. + Escapes, +} + impl Glob { pub fn to_regex(glob: &str, strict_leading_dot: bool, strict_wildcard_slash: bool) -> String { - let delimiter = '#'; - let mut first_byte = true; - let mut escaping = false; - let mut in_curlies: i64 = 0; - let mut regex = String::new(); - let bytes = glob.as_bytes(); - let size_glob = bytes.len(); - let mut i = 0; - while i < size_glob { - let mut car = (bytes[i] as char).to_string(); - if first_byte && strict_leading_dot && car != "." { - regex.push_str("(?=[^\\.])"); - } + format!( + "#^{}$#", + expand( + glob, + strict_leading_dot, + strict_wildcard_slash, + Terminal::EndAnchor + ) + ) + } - first_byte = car == "/"; + /// Not part of Symfony's Glob. Composer's BaseExcludeFilter derives its patterns + /// from toRegex output by stripping the delimiters and anchors and appending the + /// `(?=$|/)` dir-boundary look-ahead. Here that suffix has to take part in the + /// union expansion — when a trailing `*` matches zero characters, the no-dot + /// constraint falls onto the boundary itself — so it cannot be appended by the + /// caller after the fact. Returns the undelimited, unanchored body with the + /// boundary woven in as the consuming `(?:$|/)` (equivalent under boolean + /// matching, since nothing follows it). + pub fn to_regex_dir_boundary( + glob: &str, + strict_leading_dot: bool, + strict_wildcard_slash: bool, + ) -> String { + expand( + glob, + strict_leading_dot, + strict_wildcard_slash, + Terminal::EndOrSlash, + ) + } +} - if first_byte - && strict_wildcard_slash - && i + 2 < size_glob - && bytes[i + 1] == b'*' - && bytes[i + 2] == b'*' - && (i + 3 >= size_glob || bytes[i + 3] == b'/') - { - let mut new_car = String::from("[^/]++/"); - if i + 3 >= size_glob { - new_car.push('?'); - } +fn expand( + glob: &str, + strict_leading_dot: bool, + strict_wildcard_slash: bool, + terminal: Terminal, +) -> String { + let ctx = Ctx { + strict_leading_dot, + strict_wildcard_slash, + }; + let mut tokens = tokenize(glob, ctx); + tokens.push(Token::End(terminal)); + match render_seq(&tokens, ctx) { + Out::Ok(body) => body, + Out::Dead => "\\b\\B".to_string(), + Out::Escapes => unreachable!("the terminal token resolves every constraint"), + } +} - if strict_leading_dot { - new_car = format!("(?=[^\\.]){}", new_car); - } +// PHP iterates over bytes; iterating over chars is equivalent for valid UTF-8 because +// every character the loop treats specially is ASCII. +fn tokenize(glob: &str, ctx: Ctx) -> Vec<Token> { + let chars: Vec<char> = glob.chars().collect(); + let mut first_byte = true; + let mut escaping = false; + // stack[0] is the root sequence (a pseudo-group with a single alternative); deeper + // frames are open `{` groups, so PHP's $inCurlies == stack.len() - 1. + let mut stack: Vec<Vec<Vec<Token>>> = vec![vec![Vec::new()]]; - new_car = format!("/(?:{})*", new_car); - i += 2 + usize::from(i + 3 < size_glob); + fn push(stack: &mut [Vec<Vec<Token>>], token: Token) { + stack.last_mut().unwrap().last_mut().unwrap().push(token); + } - if delimiter == '/' { - new_car = new_car.replace('/', "\\/"); - } + let mut i = 0; + while i < chars.len() { + let car = chars[i]; + if first_byte && ctx.strict_leading_dot && car != '.' { + push(&mut stack, Token::NoDot); + } - car = new_car; - } + first_byte = car == '/'; + + if first_byte + && ctx.strict_wildcard_slash + && i + 2 < chars.len() + && chars[i + 1] == '*' + && chars[i + 2] == '*' + && (i + 3 >= chars.len() || chars[i + 3] == '/') + { + push( + &mut stack, + Token::Globstar { + trailing_slash_optional: i + 3 >= chars.len(), + }, + ); + i += 2 + usize::from(i + 3 < chars.len()); + escaping = false; + i += 1; + continue; + } - if car == delimiter.to_string() - || car == "." - || car == "(" - || car == ")" - || car == "|" - || car == "+" - || car == "^" - || car == "$" - { - regex.push('\\'); - regex.push_str(&car); - } else if car == "*" { - regex.push_str(if escaping { - "\\*" - } else if strict_wildcard_slash { - "[^/]*" + if car == '#' + || car == '.' + || car == '(' + || car == ')' + || car == '|' + || car == '+' + || car == '^' + || car == '$' + { + push(&mut stack, Token::Text(format!("\\{car}"))); + } else if car == '*' { + push( + &mut stack, + if escaping { + Token::Text("\\*".to_string()) } else { - ".*" - }); - } else if car == "?" { - regex.push_str(if escaping { - "\\?" - } else if strict_wildcard_slash { - "[^/]" + Token::Star + }, + ); + } else if car == '?' { + push( + &mut stack, + if escaping { + Token::Text("\\?".to_string()) } else { - "." - }); - } else if car == "{" { - regex.push_str(if escaping { "\\{" } else { "(" }); - if !escaping { - in_curlies += 1; - } - } else if car == "}" && in_curlies > 0 { - regex.push_str(if escaping { "}" } else { ")" }); - if !escaping { - in_curlies -= 1; + Token::Question + }, + ); + } else if car == '{' { + if escaping { + push(&mut stack, Token::Text("\\{".to_string())); + } else { + stack.push(vec![Vec::new()]); + } + } else if car == '}' && stack.len() > 1 { + if escaping { + push(&mut stack, Token::Text("}".to_string())); + } else { + let alternatives = stack.pop().unwrap(); + push( + &mut stack, + Token::Group { + alternatives, + closed: true, + }, + ); + } + } else if car == ',' && stack.len() > 1 { + if escaping { + push(&mut stack, Token::Text(",".to_string())); + } else { + stack.last_mut().unwrap().push(Vec::new()); + } + } else if car == '\\' { + if escaping { + push(&mut stack, Token::Text("\\\\".to_string())); + escaping = false; + } else { + escaping = true; + } + i += 1; + continue; + } else { + push(&mut stack, Token::Text(car.to_string())); + } + escaping = false; + i += 1; + } + + // PHP leaves an unterminated `(` for an unclosed `{`; keep the broken shape so the + // resulting pattern fails to compile just as the PCRE one does. + while stack.len() > 1 { + let alternatives = stack.pop().unwrap(); + push( + &mut stack, + Token::Group { + alternatives, + closed: false, + }, + ); + } + stack.pop().unwrap().pop().unwrap() +} + +fn star(ctx: Ctx) -> &'static str { + if ctx.strict_wildcard_slash { + "[^/]*" + } else { + ".*" + } +} + +fn question(ctx: Ctx) -> &'static str { + if ctx.strict_wildcard_slash { + "[^/]" + } else { + "." + } +} + +fn globstar(ctx: Ctx, trailing_slash_optional: bool) -> String { + // PHP emits `/(?:(?=[^\.])[^/]++/)*`; `(?=[^\.])[^/]+` collapses to `[^/.][^/]*`. + let step = if ctx.strict_leading_dot { + "[^/.][^/]*" + } else { + "[^/]+" + }; + let slash = if trailing_slash_optional { "/?" } else { "/" }; + format!("/(?:{step}{slash})*") +} + +fn render_seq(tokens: &[Token], ctx: Ctx) -> Out { + let mut out = String::new(); + for (idx, token) in tokens.iter().enumerate() { + match token { + Token::Text(text) => out.push_str(text), + Token::Star => out.push_str(star(ctx)), + Token::Question => out.push_str(question(ctx)), + Token::Globstar { + trailing_slash_optional, + } => out.push_str(&globstar(ctx, *trailing_slash_optional)), + Token::End(Terminal::EndAnchor) => {} + Token::End(Terminal::EndOrSlash) => out.push_str("(?:$|/)"), + Token::NoDot => { + return prefix(out, apply_no_dot(&tokens[idx + 1..], ctx)); + } + Token::Group { + alternatives, + closed, + } => match render_group_isolated(alternatives, *closed, ctx) { + Out::Ok(group) => out.push_str(&group), + Out::Dead => return Out::Dead, + Out::Escapes => { + // A constraint inside the group applies to what follows it; splice + // the remainder into each alternative and re-render. + let rest = &tokens[idx + 1..]; + let mut branches = Vec::new(); + for alternative in alternatives { + let mut seq = alternative.clone(); + seq.extend_from_slice(rest); + match render_seq(&seq, ctx) { + Out::Ok(branch) => branches.push(branch), + Out::Dead => {} + Out::Escapes => return Out::Escapes, + } + } + return match join_branches(branches) { + Some(joined) => Out::Ok(out + &joined), + None => Out::Dead, + }; } - } else if car == "," && in_curlies > 0 { - regex.push_str(if escaping { "," } else { "|" }); - } else if car == "\\" { - if escaping { - regex.push_str("\\\\"); - escaping = false; + }, + } + } + Out::Ok(out) +} + +fn render_group_isolated(alternatives: &[Vec<Token>], closed: bool, ctx: Ctx) -> Out { + let mut rendered = Vec::new(); + for alternative in alternatives { + match render_seq(alternative, ctx) { + Out::Ok(branch) => rendered.push(branch), + Out::Dead => {} + Out::Escapes => { + if !closed { + // The unterminated `(` makes the output uncompilable either way; + // resolve the dangling constraint as if the pattern ended here. + let mut seq = alternative.clone(); + seq.push(Token::End(Terminal::EndAnchor)); + if let Out::Ok(branch) = render_seq(&seq, ctx) { + rendered.push(branch); + } } else { - escaping = true; + return Out::Escapes; } + } + } + } + if rendered.is_empty() { + return Out::Dead; + } + let close = if closed { ")" } else { "" }; + Out::Ok(format!("({}{close}", rendered.join("|"))) +} - i += 1; - continue; +/// Renders the remainder of the pattern under the constraint that the next matched +/// character must not be a dot. +fn apply_no_dot(tokens: &[Token], ctx: Ctx) -> Out { + let Some((first, rest)) = tokens.split_first() else { + return Out::Escapes; + }; + match first { + Token::Text(text) if text == "\\." => Out::Dead, + Token::Text(text) if text == "[" => { + if let Some((class, after)) = scan_char_class(tokens) { + prefix( + format!("[{class}&&[^.]]"), + render_seq(&tokens[after..], ctx), + ) } else { - regex.push_str(&car); + prefix("[".to_string(), render_seq(rest, ctx)) + } + } + Token::Text(text) => prefix(text.clone(), render_seq(rest, ctx)), + Token::Star => { + // Either the `*` consumes at least one character, which then carries the + // constraint, or it consumes none and the constraint moves past it. + let head = if ctx.strict_wildcard_slash { + "[^/.][^/]*" + } else { + "[^.\\n].*" + }; + let consumed = prefix(head.to_string(), render_seq(rest, ctx)); + let skipped = apply_no_dot(rest, ctx); + match (consumed, skipped) { + (Out::Escapes, _) | (_, Out::Escapes) => Out::Escapes, + (Out::Ok(a), Out::Ok(b)) => Out::Ok(format!("(?:{a}|{b})")), + (Out::Ok(a), Out::Dead) => Out::Ok(a), + (Out::Dead, Out::Ok(b)) => Out::Ok(b), + (Out::Dead, Out::Dead) => Out::Dead, + } + } + Token::Question => { + let head = if ctx.strict_wildcard_slash { + "[^/.]" + } else { + "[^.\\n]" + }; + prefix(head.to_string(), render_seq(rest, ctx)) + } + // The construct starts with a literal `/`, which satisfies the constraint. + Token::Globstar { .. } => render_seq(tokens, ctx), + Token::Group { + alternatives, + closed: true, + } => { + let mut branches = Vec::new(); + for alternative in alternatives { + let mut seq = alternative.clone(); + seq.extend_from_slice(rest); + match apply_no_dot(&seq, ctx) { + Out::Ok(branch) => branches.push(branch), + Out::Dead => {} + Out::Escapes => return Out::Escapes, + } + } + match join_branches(branches) { + Some(joined) => Out::Ok(joined), + None => Out::Dead, } - escaping = false; - i += 1; } + // The unterminated `(` makes the output uncompilable either way; skip the + // expansion. + Token::Group { closed: false, .. } => render_seq(tokens, ctx), + // `(?=[^.])$`: no next character can exist. + Token::End(Terminal::EndAnchor) => Out::Dead, + // `(?=[^.])(?=$|/)`: the next character must exist, must not be a dot, and must + // be either the end (impossible) or a slash — exactly one consumable `/`. + Token::End(Terminal::EndOrSlash) => Out::Ok("/".to_string()), + Token::NoDot => unreachable!("PHP never emits two consecutive look-aheads"), + } +} + +fn prefix(head: String, tail: Out) -> Out { + match tail { + Out::Ok(tail) => Out::Ok(head + &tail), + other => other, + } +} - format!("{delimiter}^{regex}${delimiter}") +fn join_branches(mut branches: Vec<String>) -> Option<String> { + match branches.len() { + 0 => None, + 1 => branches.pop(), + _ => Some(format!("(?:{})", branches.join("|"))), + } +} + +/// A `[` passes through the PHP loop untouched and opens a character class in the +/// final regex, so a no-dot constraint has to intersect the class rather than be +/// satisfied by the `[` itself. Collects a class spanning plain text tokens; None when +/// no plain closing `]` follows (the `[` is then treated as a literal). +fn scan_char_class(tokens: &[Token]) -> Option<(String, usize)> { + let mut class = String::from("["); + let mut idx = 1; + loop { + match tokens.get(idx)? { + Token::Text(text) if text == "]" => { + class.push(']'); + return Some((class, idx + 1)); + } + Token::Text(text) => class.push_str(text), + _ => return None, + } + idx += 1; } } diff --git a/crates/shirabe/src/package/archiver/base_exclude_filter.rs b/crates/shirabe/src/package/archiver/base_exclude_filter.rs index fa2007fb..05bd7adc 100644 --- a/crates/shirabe/src/package/archiver/base_exclude_filter.rs +++ b/crates/shirabe/src/package/archiver/base_exclude_filter.rs @@ -59,14 +59,14 @@ impl BaseExcludeFilterBase { let rule = rule.trim_matches('/'); - let glob_regex = Glob::to_regex(rule, true, true); - let rule_regex = &glob_regex[2..glob_regex.len() - 2]; + // Regex pattern compatibility: + // PHP strips the delimiters/anchors off Glob::toRegex output and appends the + // `(?=$|/)` look-ahead, which the regex crate cannot compile. The boundary has + // to participate in Glob's no-dot union expansion, so it is woven into the + // body by to_regex_dir_boundary instead of being appended here. + let rule_regex = Glob::to_regex_dir_boundary(rule, true, true); - ( - format!("{{{}{}(?=$|/)}}", pattern, rule_regex), - negate, - false, - ) + (format!("{{{}{}}}", pattern, rule_regex), negate, false) } } diff --git a/crates/shirabe/tests/all_functional_test.rs b/crates/shirabe/tests/all_functional_test.rs index 2bd81e11..72e1cbec 100644 --- a/crates/shirabe/tests/all_functional_test.rs +++ b/crates/shirabe/tests/all_functional_test.rs @@ -259,16 +259,11 @@ fn test_integration_create_project_command() { #[test] #[serial] -#[ignore = "the former blocker (scheme-less packages.json read via RemoteFilesystem::\ - get_remote_contents) is fixed and the EXPECT-REGEX assertion itself now passes, but \ - only incidentally: the run needs live network (real git clone from github.com) and \ - still panics with exit 101 (Composer exits 0) during CreateProjectCommand's keep-vcs \ - cleanup, whose Symfony Finder name patterns go through Glob::to_regex, which \ - faithfully emits PCRE lookaheads ((?=[^\\.])) the regex crate cannot compile; the \ - fixture just never asserts the exit code. Making Glob::to_regex regex-crate-compatible \ - would change the pattern text git_exclude_filter_test::test_pattern_escape asserts \ - verbatim, so both that rewrite and un-ignoring this green-but-crashing test need a \ - user decision"] +#[ignore = "needs live network (real git clone from github.com). The two former in-process \ + blockers are fixed: the scheme-less packages.json read via RemoteFilesystem::\ + get_remote_contents, and the exit-101 panic during CreateProjectCommand's keep-vcs \ + cleanup, whose Symfony Finder name patterns go through Glob::to_regex (now \ + regex-crate-compatible); a full green run is unverified because it requires network"] fn test_integration_create_project_shows_full_hash_for_dev_packages() { run_integration("create-project-shows-full-hash-for-dev-packages.test"); } diff --git a/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs b/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs index ae9784ee..50e6a66a 100644 --- a/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs +++ b/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs @@ -105,9 +105,6 @@ fn assert_archivable_files(set_up: &SetUp, finder: ArchivableFilesFinder, expect assert_eq!(expected_files, actual_files); } -// The manual exclude patterns (e.g. `.*`, `prefixC.*`) compile, via ComposerExcludeFilter, to -// look-ahead regexes like `(?=[^\.])...(?=$|/)`, which the regex crate cannot compile. -#[ignore = "ComposerExcludeFilter builds look-ahead regexes the regex crate does not support"] #[test] fn test_manual_excludes() { let set_up = set_up(); @@ -211,15 +208,26 @@ fn get_archived_files(set_up: &SetUp, command: &str) -> Vec<String> { files } -// Faithful port, but blocked at runtime by the same look-ahead regex limitation as -// test_manual_excludes: the finder applies .gitattributes export-ignore rules through -// BaseExcludeFilter::generate_pattern, which builds `(?=$|/)` patterns the regex crate cannot -// compile. It additionally requires a `git` executable (PHP guards with skipIfNotExecutable). -#[ignore = "finder applies .gitattributes rules via BaseExcludeFilter::generate_pattern, whose \ - (?=$|/) look-ahead regexes the regex crate cannot compile (same blocker as \ - test_manual_excludes); also requires a git executable"] +/// PHP's `skipIfNotExecutable('git')`. +fn git_is_executable() -> bool { + Process::from_shell_commandline( + "git --version", + None, + None, + PhpMixed::Bool(false), + Some(60.0), + ) + .and_then(|mut p| p.run(None, IndexMap::new())) + .map(|code| code == 0) + .unwrap_or(false) +} + #[test] fn test_git_excludes() { + if !git_is_executable() { + return; + } + let set_up = set_up(); file_put_contents( diff --git a/crates/shirabe/tests/package/archiver/archive_manager_test.rs b/crates/shirabe/tests/package/archiver/archive_manager_test.rs index 3db1e734..a7235bf9 100644 --- a/crates/shirabe/tests/package/archiver/archive_manager_test.rs +++ b/crates/shirabe/tests/package/archiver/archive_manager_test.rs @@ -167,7 +167,6 @@ fn test_unknown_format() { // ref: ArchiveManagerTest::testArchiveTar / testArchiveCustomFileName. #[test] -#[ignore = "ArchiveManager::archive always passes buildExcludePatterns' glob excludes (e.g. 'name-*.zip'), which BaseExcludeFilter::generate_pattern turns into look-ahead regexes the regex crate cannot compile"] fn test_archive_tar() { if !git_is_executable() { return; @@ -204,7 +203,6 @@ fn test_archive_tar() { } #[test] -#[ignore = "ArchiveManager::archive always passes buildExcludePatterns' glob excludes (e.g. 'name-*.zip'), which BaseExcludeFilter::generate_pattern turns into look-ahead regexes the regex crate cannot compile"] fn test_archive_custom_file_name() { if !git_is_executable() { return; diff --git a/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs b/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs index ab1d6093..4fe3d331 100644 --- a/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs +++ b/crates/shirabe/tests/package/archiver/git_exclude_filter_test.rs @@ -16,7 +16,7 @@ fn provide_patterns() -> Vec<(&'static str, Option<(String, bool, bool)>)> { ( "app/config/parameters.yml export-ignore", Some(( - r"{(?=[^\.])app/(?=[^\.])config/(?=[^\.])parameters\.yml(?=$|/)}".to_string(), + r"{app/config/parameters\.yml(?:$|/)}".to_string(), false, false, )), @@ -24,7 +24,7 @@ fn provide_patterns() -> Vec<(&'static str, Option<(String, bool, bool)>)> { ( "app/config/parameters.yml -export-ignore", Some(( - r"{(?=[^\.])app/(?=[^\.])config/(?=[^\.])parameters\.yml(?=$|/)}".to_string(), + r"{app/config/parameters\.yml(?:$|/)}".to_string(), true, false, )), diff --git a/crates/shirabe/tests/package/archiver/phar_archiver_test.rs b/crates/shirabe/tests/package/archiver/phar_archiver_test.rs index 39c5087a..7d879973 100644 --- a/crates/shirabe/tests/package/archiver/phar_archiver_test.rs +++ b/crates/shirabe/tests/package/archiver/phar_archiver_test.rs @@ -64,7 +64,6 @@ impl ArchiverTestCase { } } -#[ignore = "the excludes passed here make BaseExcludeFilter::generate_pattern emit look-ahead regexes ((?=$|/) and Glob's (?=[^\\.])) that the regex crate cannot compile"] #[test] #[serial] fn test_tar_archive() { |