1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
|
//! ref: composer/tests/Composer/Test/Downloader/ZipDownloaderTest.php
use crate::io_stub::IOStub;
use indexmap::IndexMap;
use serial_test::serial;
use shirabe::config::Config;
use shirabe::downloader::ArchiveDownloader;
use shirabe::downloader::DownloaderInterface;
use shirabe::downloader::zip_downloader::ZipDownloader;
use shirabe::io::IOInterface;
use shirabe::package::handle::{CompletePackageHandle, PackageInterfaceHandle};
use shirabe::util::HttpDownloader;
use shirabe::util::ProcessExecutor;
use shirabe::util::filesystem::Filesystem;
use shirabe::util::r#loop::Loop;
use shirabe_php_shim::{PhpMixed, ZipArchive, ZipArchiveMock};
use shirabe_semver::VersionParser;
use std::cell::RefCell;
use std::rc::Rc;
use tempfile::TempDir;
fn run<F: std::future::Future>(future: F) -> F::Output {
tokio::runtime::Builder::new_current_thread()
.build()
.unwrap()
.block_on(future)
}
struct SetUp {
test_dir: TempDir,
io: Rc<RefCell<dyn IOInterface>>,
config: Rc<RefCell<Config>>,
http_downloader: Rc<RefCell<HttpDownloader>>,
package: PackageInterfaceHandle,
filename: std::path::PathBuf,
}
/// ref: ZipDownloaderTest::setUp.
///
/// The PHP test mocks IOInterface/Config/HttpDownloader/PackageInterface via PHPUnit. Here the
/// IO/Config use the existing stubs, the HttpDownloader is built as a mock (no network is touched on
/// the `extract` path exercised by the ported tests), and the package is a real CompletePackage whose
/// `getName()` is `test/pkg`, matching the PHP mock's `->method('getName')->willReturn('test/pkg')`.
fn set_up() -> SetUp {
let test_dir = TempDir::new().unwrap();
let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(IOStub::new()));
let config = Rc::new(RefCell::new(Config::new(false, None)));
let dl_config = Rc::new(RefCell::new(Config::new(false, None)));
let http_downloader = Rc::new(RefCell::new(HttpDownloader::__new_mock(
io.clone(),
dl_config,
)));
let norm_version = VersionParser.normalize("1.0.0", None).unwrap();
let package: PackageInterfaceHandle =
CompletePackageHandle::new("test/pkg".to_string(), norm_version, "1.0.0".to_string())
.into();
let filename = test_dir.path().join("composer-test.zip");
std::fs::write(&filename, "zip").unwrap();
SetUp {
test_dir,
io,
config,
http_downloader,
package,
filename,
}
}
fn tear_down(test_dir: &std::path::Path) {
let mut fs = Filesystem::new(None);
fs.remove_directory(test_dir).unwrap();
// setPrivateProperty('hasZipArchive', null)
ZipDownloader::__set_has_zip_archive(None);
}
struct TearDown {
test_dir: std::path::PathBuf,
}
impl TearDown {
fn new(test_dir: std::path::PathBuf) -> Self {
TearDown { test_dir }
}
}
impl Drop for TearDown {
fn drop(&mut self) {
tear_down(&self.test_dir);
}
}
fn make_downloader(set_up: &SetUp) -> ZipDownloader {
let filesystem = Rc::new(RefCell::new(Filesystem::new(None)));
let process = Rc::new(RefCell::new(ProcessExecutor::new(Some(set_up.io.clone()))));
ZipDownloader::new(
set_up.io.clone(),
set_up.config.clone(),
set_up.http_downloader.clone(),
None,
None,
filesystem,
process,
)
}
// The system-unzip / non-windows-fallback paths route through ProcessExecutor::execute_async, whose
// mock branch is an unimplemented todo!() (no Process mock seam exists in the external-packages
// crate). The PHP tests below mock Process/ProcessExecutor::executeAsync, which is not reproducible
// here, so they remain ignored.
//
// testErrorMessages drives a real HttpDownloader + Loop, but RemoteFilesystem::get_remote_contents
// is a phase-c stub returning None, so the file:// dist download fails before the ZipArchive path.
#[ignore = "drives a real HttpDownloader whose RemoteFilesystem::get_remote_contents is a phase-c stub returning None, so the file:// dist download fails with a \"could not be downloaded\" TransportException before reaching the ZipArchive \"is not a zip archive\" path"]
#[test]
#[serial]
fn test_error_messages() {
// class_exists('ZipArchive') is always true in the shim, so the zip-extension-missing skip never
// applies here.
let test_dir = TempDir::new().unwrap();
let _tear_down = TearDown::new(test_dir.path().to_path_buf());
let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(IOStub::new()));
// $this->config->method('get')->with('vendor-dir')->willReturn($this->testDir)
let mut config = Config::new(false, None);
let mut config_options: IndexMap<String, PhpMixed> = IndexMap::new();
config_options.insert(
"vendor-dir".to_string(),
PhpMixed::String(test_dir.path().to_string_lossy().into_owned()),
);
let mut merged: IndexMap<String, PhpMixed> = IndexMap::new();
merged.insert("config".to_string(), PhpMixed::Array(config_options));
config.merge(&merged, "test");
let config = Rc::new(RefCell::new(config));
// new HttpDownloader($this->io, $dlConfig): a real downloader (not the extract-path mock).
let dl_config = Rc::new(RefCell::new(Config::new(false, None)));
let http_downloader = Rc::new(RefCell::new(HttpDownloader::new(
io.clone(),
dl_config,
IndexMap::new(),
false,
)));
// $distUrl = 'file://'.__FILE__: an existing, non-zip file referenced by a file:// URL.
let dist_url = format!("file://{}/Cargo.toml", env!("CARGO_MANIFEST_DIR"));
let norm_version = VersionParser.normalize("1.0.0", None).unwrap();
let package: PackageInterfaceHandle =
CompletePackageHandle::new("test/pkg".to_string(), norm_version, "1.0.0".to_string())
.into();
package.set_dist_url(Some(dist_url));
let filesystem = Rc::new(RefCell::new(Filesystem::new(None)));
let process = Rc::new(RefCell::new(ProcessExecutor::new(Some(io.clone()))));
let mut downloader = ZipDownloader::new(
io,
config,
http_downloader.clone(),
None,
None,
filesystem,
process,
);
let path = std::env::temp_dir()
.join("composer-zip-test")
.to_string_lossy()
.into_owned();
let result: anyhow::Result<()> = (|| {
let mut loop_ = Loop::new(http_downloader.clone(), None);
let promise = Box::pin(async {
DownloaderInterface::download(&mut downloader, package.clone(), &path, None, true)
.await
.map(|_| ())
});
run(loop_.wait(vec![promise], None))?;
run(DownloaderInterface::install(
&mut downloader,
package.clone(),
&path,
true,
))
.map(|_| ())
})();
let e = result.expect_err("Download of invalid zip files should throw an exception");
assert!(e.to_string().contains("is not a zip archive"), "got: {e}");
}
#[test]
#[serial]
fn test_zip_archive_only_failed() {
let set_up = set_up();
let _tear_down = TearDown::new(set_up.test_dir.path().to_path_buf());
ZipDownloader::__set_has_zip_archive(Some(true));
let mut downloader = make_downloader(&set_up);
let zip_archive = ZipArchive::__mock(ZipArchiveMock {
open: Ok(()),
count: 0,
extract_to: Ok(false),
});
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
let e = result.expect_err("expected RuntimeException");
assert!(
e.to_string()
.contains("There was an error extracting the ZIP file"),
"got: {e}"
);
}
#[test]
#[serial]
fn test_zip_archive_extract_only_failed() {
let set_up = set_up();
let _tear_down = TearDown::new(set_up.test_dir.path().to_path_buf());
ZipDownloader::__set_has_zip_archive(Some(true));
let mut downloader = make_downloader(&set_up);
let zip_archive = ZipArchive::__mock(ZipArchiveMock {
open: Ok(()),
count: 0,
extract_to: Err("Not a directory".to_string()),
});
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
let e = result.expect_err("expected RuntimeException");
assert!(
e.to_string().contains(
"The archive for \"test/pkg\" may contain identical file names with different \
capitalization (which fails on case insensitive filesystems): Not a directory"
),
"got: {e}"
);
}
#[test]
#[serial]
fn test_zip_archive_only_good() {
let set_up = set_up();
let _tear_down = TearDown::new(set_up.test_dir.path().to_path_buf());
ZipDownloader::__set_has_zip_archive(Some(true));
let mut downloader = make_downloader(&set_up);
let zip_archive = ZipArchive::__mock(ZipArchiveMock {
open: Ok(()),
count: 0,
extract_to: Ok(true),
});
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
result.expect("extract should succeed");
}
#[ignore = "routes through ProcessExecutor::execute_async whose mock branch is todo!() (no Process mock seam in external-packages)"]
#[test]
fn test_system_unzip_only_failed() {
let _ = set_up();
todo!()
}
#[ignore = "routes through ProcessExecutor::execute_async whose mock branch is todo!() (no Process mock seam in external-packages)"]
#[test]
fn test_system_unzip_only_good() {
let _ = set_up();
todo!()
}
#[ignore = "routes through ProcessExecutor::execute_async whose mock branch is todo!() (no Process mock seam in external-packages)"]
#[test]
fn test_non_windows_fallback_good() {
let _ = set_up();
todo!()
}
#[ignore = "routes through ProcessExecutor::execute_async whose mock branch is todo!() (no Process mock seam in external-packages)"]
#[test]
fn test_non_windows_fallback_failed() {
let _ = set_up();
todo!()
}
|