1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
|
//! ref: composer/tests/Composer/Test/Installer/LibraryInstallerTest.php
use std::cell::RefCell;
use std::fs;
use std::rc::Rc;
use indexmap::IndexMap;
use tempfile::TempDir;
use shirabe::composer::{
ComposerHandle, PartialComposerHandle, PartialComposerWeakHandle, PartialOrFullComposer,
};
use shirabe::config::Config;
use shirabe::downloader::{DownloadManagerInterface, DownloaderInterface};
use shirabe::installer::{BinaryInstallerInterface, InstallerInterface, LibraryInstaller};
use shirabe::io::IOInterface;
use shirabe::io::null_io::NullIO;
use shirabe::package::PackageInterfaceHandle;
use shirabe::repository::InstalledArrayRepository;
use shirabe::repository::RepositoryInterface;
use shirabe::repository::WritableRepositoryInterface;
use shirabe::util::filesystem::Filesystem;
use shirabe_php_shim::PhpMixed;
use crate::test_case::get_package;
// PHP mocks `Composer\Downloader\DownloadManager` with getMockBuilder and asserts its
// install/update/remove calls; here the equivalent mock is injected into the Composer via
// setDownloadManager.
mockall::mock! {
#[derive(Debug)]
pub DownloadManager {}
#[async_trait::async_trait(?Send)]
impl DownloadManagerInterface for DownloadManager {
fn set_prefer_source(&mut self, prefer_source: bool);
fn set_prefer_dist(&mut self, prefer_dist: bool);
fn get_downloader_for_package(
&self,
package: PackageInterfaceHandle,
) -> anyhow::Result<Option<Rc<RefCell<dyn DownloaderInterface>>>>;
async fn download(
&self,
package: PackageInterfaceHandle,
target_dir: &str,
prev_package: Option<PackageInterfaceHandle>,
) -> anyhow::Result<Option<PhpMixed>>;
async fn prepare(
&self,
r#type: &str,
package: PackageInterfaceHandle,
target_dir: &str,
prev_package: Option<PackageInterfaceHandle>,
) -> anyhow::Result<Option<PhpMixed>>;
async fn install(
&self,
package: PackageInterfaceHandle,
target_dir: &str,
) -> anyhow::Result<Option<PhpMixed>>;
async fn update(
&self,
initial: PackageInterfaceHandle,
target: PackageInterfaceHandle,
target_dir: &str,
) -> anyhow::Result<Option<PhpMixed>>;
async fn remove(
&self,
package: PackageInterfaceHandle,
target_dir: &str,
) -> anyhow::Result<Option<PhpMixed>>;
async fn cleanup(
&self,
r#type: &str,
package: PackageInterfaceHandle,
target_dir: &str,
prev_package: Option<PackageInterfaceHandle>,
) -> anyhow::Result<Option<PhpMixed>>;
}
}
// PHP mocks `Composer\Installer\BinaryInstaller`; the Rust seam is `BinaryInstallerInterface`.
mockall::mock! {
#[derive(Debug)]
pub BinaryInstaller {}
impl BinaryInstallerInterface for BinaryInstaller {
fn install_binaries(
&mut self,
package: PackageInterfaceHandle,
install_path: &str,
warn_on_overwrite: bool,
);
fn remove_binaries(&mut self, package: PackageInterfaceHandle);
}
}
fn run<F: std::future::Future>(future: F) -> F::Output {
tokio::runtime::Builder::new_current_thread()
.build()
.unwrap()
.block_on(future)
}
/// Mirror of setUp(): builds the Composer/Config over temp root/vendor/bin dirs plus a NullIO and a
/// DownloadManager mock. `composer_full` keeps the inner Rc alive for the duration of the test since
/// LibraryInstaller only holds a weak handle, and lets tests swap in a configured DownloadManager
/// mock before constructing the installer.
struct SetUp {
root: TempDir,
vendor_dir: String,
bin_dir: String,
io: Rc<RefCell<dyn IOInterface>>,
composer: PartialComposerWeakHandle,
fs: Filesystem,
composer_full: ComposerHandle,
}
/// Replaces the Composer's DownloadManager with the given mock. Must be called before
/// `LibraryInstaller::new`, which captures the manager at construction time.
fn set_download_manager(setup: &SetUp, dm: MockDownloadManager) {
setup
.composer_full
.borrow_mut()
.set_download_manager(Rc::new(RefCell::new(dm)));
}
fn set_up() -> SetUp {
let fs = Filesystem::new(None);
let root = TempDir::new().unwrap();
let root_dir = fs::canonicalize(root.path())
.unwrap()
.to_string_lossy()
.into_owned();
let vendor_dir = format!("{}/vendor", root_dir);
fs::create_dir_all(&vendor_dir).unwrap();
let bin_dir = format!("{}/bin", root_dir);
fs::create_dir_all(&bin_dir).unwrap();
let mut config = Config::new(false, None);
let mut config_section: IndexMap<String, PhpMixed> = IndexMap::new();
config_section.insert(
"vendor-dir".to_string(),
PhpMixed::String(vendor_dir.clone()),
);
config_section.insert("bin-dir".to_string(), PhpMixed::String(bin_dir.clone()));
let mut merged: IndexMap<String, PhpMixed> = IndexMap::new();
merged.insert("config".to_string(), PhpMixed::Array(config_section));
config.merge(&merged, Config::SOURCE_UNKNOWN);
let config_rc = Rc::new(RefCell::new(config));
let io: Rc<RefCell<dyn IOInterface>> = Rc::new(RefCell::new(NullIO::new()));
let composer_rc = Rc::new(RefCell::new(PartialOrFullComposer::new_full()));
let composer = ComposerHandle::from_rc_unchecked(composer_rc.clone());
composer.borrow_mut().set_config(config_rc);
// Default unconfigured mock so LibraryInstaller::new can resolve a DownloadManager even in
// tests that exercise no downloader call; tests that assert calls install their own via
// set_download_manager.
composer
.borrow_mut()
.set_download_manager(Rc::new(RefCell::new(MockDownloadManager::new())));
let weak = PartialComposerHandle::from_rc(composer_rc).downgrade();
SetUp {
root,
vendor_dir,
bin_dir,
io,
composer: weak,
fs,
composer_full: composer,
}
}
fn tear_down(setup: &mut SetUp) {
let root = setup.root.path().to_path_buf();
setup.fs.remove_directory(&root).ok();
}
#[test]
fn test_installer_creation_should_not_create_vendor_directory() {
let mut setup = set_up();
setup.fs.remove_directory(&setup.vendor_dir).unwrap();
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
assert!(!std::path::Path::new(&setup.vendor_dir).exists());
tear_down(&mut setup);
}
#[test]
fn test_installer_creation_should_not_create_bin_directory() {
let mut setup = set_up();
setup.fs.remove_directory(&setup.bin_dir).unwrap();
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
assert!(!std::path::Path::new(&setup.bin_dir).exists());
tear_down(&mut setup);
}
#[test]
fn test_is_installed() {
let mut setup = set_up();
let mut library =
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
let package = get_package("test/pkg", "1.0.0");
let mut repository = InstalledArrayRepository::new().unwrap();
assert!(!library.is_installed(&repository, package.clone()));
// package being in repo is not enough to be installed
repository.add_package(package.clone()).unwrap();
assert!(!library.is_installed(&repository, package.clone()));
// package being in repo and vendor/pkg/foo dir present means it is seen as installed
let pkg_dir = format!("{}/{}", setup.vendor_dir, package.get_pretty_name());
fs::create_dir_all(&pkg_dir).unwrap();
assert!(library.is_installed(&repository, package.clone()));
repository.remove_package(package.clone()).unwrap();
assert!(!library.is_installed(&repository, package));
tear_down(&mut setup);
}
#[test]
fn test_install() {
let mut setup = set_up();
let package = get_package("some/package", "1.0.0");
// PHP asserts the DownloadManager mock's install() is called once with
// ($package, vendorDir/some/package).
let mut dm = MockDownloadManager::new();
let expected_package = package.clone();
let expected_path = format!("{}/some/package", setup.vendor_dir);
dm.expect_install()
.times(1)
.withf_st(move |package, target_dir| {
Rc::ptr_eq(package.as_rc(), expected_package.as_rc())
&& target_dir == expected_path.as_str()
})
.returning(|_, _| Ok(None));
set_download_manager(&setup, dm);
let mut library =
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
let mut repository = InstalledArrayRepository::new().unwrap();
run(library.install(&mut repository, package.clone())).unwrap();
// PHP asserts repository->addPackage was called once with $package.
assert!(repository.has_package(package));
assert!(
std::path::Path::new(&setup.vendor_dir).exists(),
"Vendor dir should be created"
);
assert!(
std::path::Path::new(&setup.bin_dir).exists(),
"Bin dir should be created"
);
tear_down(&mut setup);
}
#[test]
fn test_update() {
let mut setup = set_up();
let initial = get_package("vendor/package1", "1.0.0");
let target = get_package("vendor/package1", "2.0.0");
initial.__set_target_dir(Some("oldtarget".to_string()));
target.__set_target_dir(Some("newtarget".to_string()));
// PHP mocks Filesystem::rename; here a real Filesystem renames the actual oldtarget
// dir, so it must exist first. The install path embeds the pretty-name twice because
// the package is named vendor/package1 and lives under vendorDir.
let old_target_dir = format!("{}/vendor/package1/oldtarget", setup.vendor_dir);
let new_target_dir = format!("{}/vendor/package1/newtarget", setup.vendor_dir);
fs::create_dir_all(&old_target_dir).unwrap();
// PHP asserts the DownloadManager mock's update() is called once with
// ($initial, $target, vendorDir/vendor/package1/newtarget).
let mut dm = MockDownloadManager::new();
let expected_initial = initial.clone();
let expected_target = target.clone();
let expected_path = new_target_dir.clone();
dm.expect_update()
.times(1)
.withf_st(move |initial, target, target_dir| {
Rc::ptr_eq(initial.as_rc(), expected_initial.as_rc())
&& Rc::ptr_eq(target.as_rc(), expected_target.as_rc())
&& target_dir == expected_path.as_str()
})
.returning(|_, _, _| Ok(None));
set_download_manager(&setup, dm);
let mut repository = InstalledArrayRepository::new().unwrap();
repository.add_package(initial.clone()).unwrap();
// The default Filesystem is fine; the LibraryInstaller's own filesystem performs the rename.
let mut library =
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
run(library.update(&mut repository, initial.clone(), target.clone())).unwrap();
assert!(
std::path::Path::new(&new_target_dir).exists(),
"oldtarget should have been renamed to newtarget"
);
assert!(!std::path::Path::new(&old_target_dir).exists());
assert!(!repository.has_package(initial.clone()));
assert!(repository.has_package(target.clone()));
assert!(
std::path::Path::new(&setup.vendor_dir).exists(),
"Vendor dir should be created"
);
assert!(
std::path::Path::new(&setup.bin_dir).exists(),
"Bin dir should be created"
);
// Updating again, with the initial package no longer installed, fails.
assert!(run(library.update(&mut repository, initial, target)).is_err());
tear_down(&mut setup);
}
#[test]
fn test_uninstall() {
let mut setup = set_up();
let package = get_package("vendor/pkg", "1.0.0");
// PHP asserts the DownloadManager mock's remove() is called once with
// ($package, vendorDir/vendor/pkg).
let mut dm = MockDownloadManager::new();
let expected_package = package.clone();
let expected_path = format!("{}/vendor/pkg", setup.vendor_dir);
dm.expect_remove()
.times(1)
.withf_st(move |package, target_dir| {
Rc::ptr_eq(package.as_rc(), expected_package.as_rc())
&& target_dir == expected_path.as_str()
})
.returning(|_, _| Ok(None));
set_download_manager(&setup, dm);
let mut library =
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
// PHP mocks hasPackage to return (true, false) over two calls; a real repository
// seeded with the package reproduces this naturally: present, then absent after
// the first uninstall removes it.
let mut repository = InstalledArrayRepository::new().unwrap();
repository.add_package(package.clone()).unwrap();
run(library.uninstall(&mut repository, package.clone())).unwrap();
assert!(!repository.has_package(package.clone()));
// Uninstalling again, with the package no longer installed, fails.
assert!(run(library.uninstall(&mut repository, package)).is_err());
tear_down(&mut setup);
}
#[test]
fn test_get_install_path_without_target_dir() {
let mut setup = set_up();
let mut library =
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
let package = get_package("Vendor/Pkg", "1.0.0");
assert_eq!(
format!("{}/{}", setup.vendor_dir, package.get_pretty_name()),
library.get_install_path(package).unwrap()
);
tear_down(&mut setup);
}
#[test]
fn test_get_install_path_with_target_dir() {
let mut setup = set_up();
let mut library =
LibraryInstaller::new(setup.io.clone(), setup.composer.clone(), None, None, None);
let package = get_package("Foo/Bar", "1.0.0");
package.__set_target_dir(Some("Some/Namespace".to_string()));
assert_eq!(
format!(
"{}/{}/Some/Namespace",
setup.vendor_dir,
package.get_pretty_name()
),
library.get_install_path(package).unwrap()
);
tear_down(&mut setup);
}
#[test]
fn test_ensure_binaries_installed() {
let mut setup = set_up();
let mut library = LibraryInstaller::new(
setup.io.clone(),
setup.composer.clone(),
Some("library".to_string()),
None,
None,
);
let package = get_package("foo/bar", "1.0.0");
let expected_path = library.get_install_path(package.clone()).unwrap();
let mut binary_installer = MockBinaryInstaller::new();
// PHP asserts removeBinaries is never called.
binary_installer.expect_remove_binaries().times(0);
// PHP asserts installBinaries is called once with ($package, getInstallPath, false).
let expected_package = package.clone();
let expected_install_path = expected_path.clone();
binary_installer
.expect_install_binaries()
.times(1)
.withf_st(move |package, install_path, warn_on_overwrite| {
Rc::ptr_eq(package.as_rc(), expected_package.as_rc())
&& install_path == expected_install_path.as_str()
&& !*warn_on_overwrite
})
.returning(|_, _, _| ());
library.__set_binary_installer(Rc::new(RefCell::new(binary_installer)));
library.ensure_binaries_presence(package.clone());
tear_down(&mut setup);
}
|