perf: optimize memory.init/table.init

4 files changed, 30 insertions, 14 deletions

diff --git a/benchmarks/20240313-2337.log b/benchmarks/20240313-2337.log
new file mode 100644
index 0000000..1dc18ff
--- /dev/null
+++ b/benchmarks/20240313-2337.log
@@ -0,0 +1,4 @@
+Benchmark 1: make run
+  Time (mean ± σ):      6.650 s ±  0.057 s    [User: 6.569 s, System: 0.080 s]
+  Range (min … max):    6.595 s …  6.800 s    10 runs
+ 
diff --git a/src/Execution/MemInst.php b/src/Execution/MemInst.php
index ae3809d..20a0e29 100644
--- a/src/Execution/MemInst.php
+++ b/src/Execution/MemInst.php
@@ -30,6 +30,21 @@ final class MemInst
     }
 
     /**
+     * @param list<int> $data
+     */
+    public function copyData(array $data, int $src, int $dst, int $len): void
+    {
+        assert(0 <= $len);
+        assert(0 <= $src);
+        assert(0 <= $dst);
+        assert($src + $len <= count($data));
+        assert($dst + $len <= $this->size());
+        for ($i = 0; $i < $len; $i++) {
+            $this->storeByte($dst + $i, $data[$src + $i]);
+        }
+    }
+
+    /**
      * @return ?S32
      */
     public function loadI32(int $ptr, int $n, bool $signed): ?int
diff --git a/src/Execution/Runtime.php b/src/Execution/Runtime.php
index 162c8b5..798209d 100644
--- a/src/Execution/Runtime.php
+++ b/src/Execution/Runtime.php
@@ -1645,12 +1645,8 @@ final class Runtime
             throw new TrapException("table.init: out of bounds");
         }
         for ($i = 0; $i < $n; $i++) {
-            $val = $elem->elem[$s];
-            $this->stack->pushValue($d);
-            $this->stack->pushValue($val);
-            $this->execInstr(Instr::TableSet($x));
-            $d++;
-            $s++;
+            // @phpstan-ignore-next-line
+            $tab->elem[$d + $i] = $elem->elem[$s + $i];
         }
     }
 
@@ -1830,14 +1826,7 @@ final class Runtime
         if ($mem->size() < $d + $n) {
             throw new TrapException("memory.init: out of bounds");
         }
-        for ($i = 0; $i < $n; $i++) {
-            $b = $data->data[$s];
-            $this->stack->pushValue($d);
-            $this->stack->pushValue($b);
-            $this->execInstr(Instr::I32Store8(0, 0));
-            $d++;
-            $s++;
-        }
+        $mem->copyData($data->data, $s, $d, $n);
     }
 
     private function execInstrMemoryMemorySize(Instrs\Memory\MemorySize $instr): void
diff --git a/traces/20240313-2337.stderr.log b/traces/20240313-2337.stderr.log
new file mode 100644
index 0000000..39e25fe
--- /dev/null
+++ b/traces/20240313-2337.stderr.log
@@ -0,0 +1,8 @@
+Decoding...
+Instantiating...
+Executing...
+
+Exit code: 0
+Memory peak usage: 195919096
+
+