diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-05-03 11:55:03 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-05-03 11:55:03 +0900 |
| commit | ae1aa6540761e54a76b8f7984cf93cd3a0d011d0 (patch) | |
| tree | f111e1c73977f0bffb6323b03f4210269b43b297 /crates/mozart-sat-resolver/src/decisions.rs | |
| parent | 30ae6c869adc7f3cb87a4d63edd6d0cda89d571d (diff) | |
| download | php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.gz php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.tar.zst php-mozart-ae1aa6540761e54a76b8f7984cf93cd3a0d011d0.zip | |
refactor: switch internal maps/sets from HashMap to IndexMap
Adopt indexmap workspace-wide so iteration order is deterministic and
follows insertion order. The non-deterministic order of std HashMap
otherwise leaks into resolver decisions when multiple valid solutions
exist (e.g. cyclic require pairs under prefer-lowest), making behavior
flaky and divergent from Composer's PHP-array semantics.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/mozart-sat-resolver/src/decisions.rs')
| -rw-r--r-- | crates/mozart-sat-resolver/src/decisions.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crates/mozart-sat-resolver/src/decisions.rs b/crates/mozart-sat-resolver/src/decisions.rs index abfbe3d..e9cc935 100644 --- a/crates/mozart-sat-resolver/src/decisions.rs +++ b/crates/mozart-sat-resolver/src/decisions.rs @@ -1,7 +1,7 @@ use crate::error::SolverBugError; use crate::pool::{Literal, PackageId, literal_to_package_id}; use crate::rule_set::RuleId; -use std::collections::HashMap; +use indexmap::IndexMap; /// A decision entry: which literal was decided and which rule caused it. #[derive(Debug, Clone)] @@ -16,7 +16,7 @@ pub struct Decision { pub struct Decisions { /// Package ID → signed level. Positive = install, negative = uninstall. /// The absolute value is the decision level. - decision_map: HashMap<PackageId, i32>, + decision_map: IndexMap<PackageId, i32>, /// Queue of decisions in order. decision_queue: Vec<Decision>, } @@ -24,7 +24,7 @@ pub struct Decisions { impl Decisions { pub fn new() -> Self { Decisions { - decision_map: HashMap::new(), + decision_map: IndexMap::new(), decision_queue: Vec::new(), } } |
