refactor(php-shim): replace literal sprintf calls with format!

Convert every sprintf() call with a compile-time literal format string to
format!, implementing Display for PhpMixed (delegating to php_to_string) so
PhpMixed values render with PHP string semantics through {}. Also merge the
format!-wrapped and conditional-literal dynamic sites into single format!
calls. Genuinely runtime format strings (table styles, configurable error
messages, command synopsis, progress-bar modifiers, regex-built messages)
still go through sprintf.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 16 insertions, 20 deletions

diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs
index 5ec5c95..1fec085 100644
--- a/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs
@@ -256,20 +256,18 @@ impl MarkdownDescriptor {
                 &command_names
                     .iter()
                     .map(|command_name| {
-                        Ok(shirabe_php_shim::sprintf(
-                            "* [`%s`](#%s)",
-                            &[
-                                PhpMixed::String(command_name.clone()),
-                                PhpMixed::String(shirabe_php_shim::str_replace(
-                                    ":",
-                                    "",
-                                    &description
-                                        .get_command(command_name)?
-                                        .borrow()
-                                        .get_name()
-                                        .unwrap_or_default(),
-                                )),
-                            ],
+                        Ok(format!(
+                            "* [`{}`](#{})",
+                            PhpMixed::String(command_name.clone()),
+                            PhpMixed::String(shirabe_php_shim::str_replace(
+                                ":",
+                                "",
+                                &description
+                                    .get_command(command_name)?
+                                    .borrow()
+                                    .get_name()
+                                    .unwrap_or_default(),
+                            )),
                         ))
                     })
                     .collect::<anyhow::Result<Vec<String>>>()?
@@ -294,12 +292,10 @@ impl MarkdownDescriptor {
     fn get_application_title(&self, application: &Application) -> String {
         if "UNKNOWN" != application.get_name() {
             if "UNKNOWN" != application.get_version() {
-                return shirabe_php_shim::sprintf(
-                    "%s %s",
-                    &[
-                        PhpMixed::String(application.get_name()),
-                        PhpMixed::String(application.get_version()),
-                    ],
+                return format!(
+                    "{} {}",
+                    PhpMixed::String(application.get_name()),
+                    PhpMixed::String(application.get_version()),
                 );
             }