aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-26 01:55:03 +0900
committernsfisis <nsfisis@gmail.com>2026-06-26 01:55:03 +0900
commitcbb5118318706dc023eb8551b1f2628f395a6228 (patch)
tree35c86c3191c2bfdb154fdfae7ad6f3292c0261f8 /crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
parent939359f13acfe8dbf4f16dac517fcbd67d46f611 (diff)
downloadphp-shirabe-cbb5118318706dc023eb8551b1f2628f395a6228.tar.gz
php-shirabe-cbb5118318706dc023eb8551b1f2628f395a6228.tar.zst
php-shirabe-cbb5118318706dc023eb8551b1f2628f395a6228.zip
refactor(symfony-table): model rows/cells with enums instead of PhpMixed
The Table helper modeled a row's cells as PhpMixed and recovered the concrete TableCell/TableSeparator types via runtime instance_of, leaving the entire mixed/array bridge (to_row_vec, cell_colspan, row_get, ...) as todo!(). Replace that with proper Row/Cell enums: Row = HeaderDivider | Separator(TableSeparator) | Cells(Vec<Cell>) Cell = Null | Value(String) | Cell(TableCell) | Separator(TableSeparator) The internal header/body boundary that PHP detects by object identity ($divider === $row) becomes the dedicated Row::HeaderDivider variant. Style arguments (PHP string|TableStyle) become a StyleName enum, so Table::new no longer panics in resolve_style's instance_of stub; TableStyle derives Clone so named styles resolve from the registry. PhpMixed-based callers (SymfonyStyle::table, render_table, auditor's sanitize) bridge via From<PhpMixed> for Cell/Row at the boundary. Un-ignores LicensesCommandTest text-format cases (4) and BaseDependencyCommandTest::why; output matches PHP exactly. Removes ~15 impl todo!()s in the Table helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs')
-rw-r--r--crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs16
1 files changed, 16 insertions, 0 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
index bb789f2..34626cc 100644
--- a/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
@@ -22,6 +22,22 @@ impl TableSeparator {
inner: TableCell::new("", options)?,
})
}
+
+ // PHP `TableSeparator extends TableCell`, so these inherited accessors remain available.
+ pub fn get_colspan(&self) -> i64 {
+ self.inner.get_colspan()
+ }
+
+ pub fn get_rowspan(&self) -> i64 {
+ self.inner.get_rowspan()
+ }
+
+ pub fn get_style(
+ &self,
+ ) -> Option<std::rc::Rc<crate::symfony::console::helper::table_cell_style::TableCellStyle>>
+ {
+ self.inner.get_style()
+ }
}
impl Default for TableSeparator {