diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-14 13:08:21 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-14 13:08:21 +0900 |
| commit | d7c686f6c488739fc9d061bb0f89d73e6445fade (patch) | |
| tree | e3b694c9e96486a13032e63e616a1ed920edd90a /crates/shirabe-external-packages/src/symfony/console/question | |
| parent | cfd2a4488797ddaabd0087aa0021b26892663ffb (diff) | |
| download | php-shirabe-d7c686f6c488739fc9d061bb0f89d73e6445fade.tar.gz php-shirabe-d7c686f6c488739fc9d061bb0f89d73e6445fade.tar.zst php-shirabe-d7c686f6c488739fc9d061bb0f89d73e6445fade.zip | |
refactor(pcre): return bool from preg_match shim
preg_match can only return 1 or 0 now that compile failure panics, so
return bool and update all call sites accordingly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony/console/question')
| -rw-r--r-- | crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs | 5 | ||||
| -rw-r--r-- | crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs b/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs index 3990df3..9de2d05 100644 --- a/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs +++ b/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs @@ -113,12 +113,11 @@ impl ChoiceQuestion { let selected_choices: Vec<PhpMixed> = if multiselect { // Check for a separated comma values let mut matches: Vec<Option<String>> = Vec::new(); - if shirabe_php_shim::preg_match( + if !shirabe_php_shim::preg_match( "/^[^,]+(?:,[^,]+)*$/", &shirabe_php_shim::strval(&selected), &mut matches, - ) == 0 - { + ) { return Err(InvalidArgumentException( shirabe_php_shim::InvalidArgumentException { message: shirabe_php_shim::sprintf(&error_message, &[selected.clone()]), diff --git a/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs b/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs index d52c435..5076d84 100644 --- a/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs +++ b/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs @@ -42,7 +42,7 @@ impl ConfirmationQuestion { ®ex, &shirabe_php_shim::strval(&answer), &mut matches, - ) != 0 + ) }; // false === $default |
