refactor(php-shim): drop Box wrapping from PhpMixed List/Array

The List and Array variants of PhpMixed boxed their elements
unnecessarily. Store PhpMixed values directly and update all callers
accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 6 insertions, 9 deletions

diff --git a/crates/shirabe-external-packages/src/symfony/console/terminal.rs b/crates/shirabe-external-packages/src/symfony/console/terminal.rs
index 9ac1f9e..377d344 100644
--- a/crates/shirabe-external-packages/src/symfony/console/terminal.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/terminal.rs
@@ -210,12 +210,12 @@ impl Terminal {
 
         let descriptorspec: Vec<PhpMixed> = vec![
             PhpMixed::List(vec![
-                Box::new(PhpMixed::String("pipe".to_string())),
-                Box::new(PhpMixed::String("w".to_string())),
+                PhpMixed::String("pipe".to_string()),
+                PhpMixed::String("w".to_string()),
             ]),
             PhpMixed::List(vec![
-                Box::new(PhpMixed::String("pipe".to_string())),
-                Box::new(PhpMixed::String("w".to_string())),
+                PhpMixed::String("pipe".to_string()),
+                PhpMixed::String("w".to_string()),
             ]),
         ];
 
@@ -248,13 +248,10 @@ impl Terminal {
 /// Indexes into the `$pipes` array populated by proc_open.
 fn php_pipe(pipes: &PhpMixed, index: i64) -> PhpMixed {
     match pipes {
-        PhpMixed::List(list) => list
-            .get(index as usize)
-            .map(|v| (**v).clone())
-            .unwrap_or(PhpMixed::Null),
+        PhpMixed::List(list) => list.get(index as usize).cloned().unwrap_or(PhpMixed::Null),
         PhpMixed::Array(array) => array
             .get(&index.to_string())
-            .map(|v| (**v).clone())
+            .map(|v| v.clone())
             .unwrap_or(PhpMixed::Null),
         _ => PhpMixed::Null,
     }