diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:27:36 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-02 16:29:08 +0900 |
| commit | 9efc866ae2553a9c51abae7214f62dde4f5f053c (patch) | |
| tree | d3749ced8b4e32713d4f5e3e88a34b501c4b4918 /crates/shirabe-php-shim/src/zip.rs | |
| parent | 6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (diff) | |
| download | php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.gz php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.zst php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.zip | |
chore(todo): consolidate TODO comments into the five fixed marker tags
Retag every Shirabe-authored TODO comment to one of the fixed tags:
phase-c, phase-d, plugin, php-runtime, phase-e.
Upstream-authored TODO comments from Composer/Symfony are left
untouched to preserve the ported code shape.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe-php-shim/src/zip.rs')
| -rw-r--r-- | crates/shirabe-php-shim/src/zip.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/shirabe-php-shim/src/zip.rs b/crates/shirabe-php-shim/src/zip.rs index 93b65fd5..83dd70ce 100644 --- a/crates/shirabe-php-shim/src/zip.rs +++ b/crates/shirabe-php-shim/src/zip.rs @@ -248,7 +248,7 @@ impl ZipArchive { } pub fn set_external_attributes_name(&self, _name: &str, _opsys: i64, _attr: i64) -> bool { - // TODO(phase-d): PHP's setExternalAttributesName mutates an already-added + // TODO(phase-c): PHP's setExternalAttributesName mutates an already-added // entry's external attributes (e.g. Unix permissions) after addFile. The // `zip` crate fixes external attributes at start_file time via FileOptions // and exposes no API to amend a written entry, so this cannot be faithfully |