aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/command/diagnose_command.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-25 16:16:33 +0900
committernsfisis <nsfisis@gmail.com>2026-07-25 16:17:10 +0900
commit432472808051cb4f1bb9517b858dbc810aaa5a63 (patch)
tree4c58b97942853ea2c3f58368203fa93187746cf8 /crates/shirabe/src/command/diagnose_command.rs
parentd4608662f28b9a5135986b1702afe3199957eabe (diff)
downloadphp-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.gz
php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.zst
php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.zip
refactor: replace redundant clones with moves
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/command/diagnose_command.rs')
-rw-r--r--crates/shirabe/src/command/diagnose_command.rs11
1 files changed, 4 insertions, 7 deletions
diff --git a/crates/shirabe/src/command/diagnose_command.rs b/crates/shirabe/src/command/diagnose_command.rs
index ac15e1d1..9d0ee6f4 100644
--- a/crates/shirabe/src/command/diagnose_command.rs
+++ b/crates/shirabe/src/command/diagnose_command.rs
@@ -103,7 +103,7 @@ impl Command for DiagnoseCommand {
let config: std::rc::Rc<std::cell::RefCell<Config>>;
if let Some(ref mut c) = composer {
let c = crate::composer::composer_full(c);
- config = c.get_config().clone();
+ config = c.get_config();
let command_event = CommandEvent::new6(
PluginEvents::COMMAND,
@@ -187,7 +187,7 @@ impl Command for DiagnoseCommand {
crate::repository::FindPackageConstraint::String("*".to_string()),
)?
.unwrap();
- let mut php_version = php_pkg.get_pretty_version().to_string();
+ let mut php_version = php_pkg.get_pretty_version();
if let Some(cp) = php_pkg.as_complete()
&& str_contains(&cp.get_description().unwrap_or_default(), "overridden")
{
@@ -986,11 +986,8 @@ impl DiagnoseCommand {
if version != "@package_version@" {
let version_parser = VersionParser::new();
let normalized_version = version_parser.normalize(&version, None)?;
- let root_pkg = RootPackage::new(
- "composer/composer".to_string(),
- normalized_version,
- version.clone(),
- );
+ let root_pkg =
+ RootPackage::new("composer/composer".to_string(), normalized_version, version);
packages.push(crate::package::RootPackageHandle::from_root_package(root_pkg).into());
}
let mut repo_config: IndexMap<String, PhpMixed> = IndexMap::new();