diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-07 14:15:55 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-07 14:15:55 +0900 |
| commit | da6f05c12d08ac96b4286664cd8205d3fee042d8 (patch) | |
| tree | 7fb50447d73d04544edb224346604f294b450f95 /crates/shirabe/src/dependency_resolver/local_repo_transaction.rs | |
| parent | 86961b16b2f5c9c26a776193934d13ff87ab7fea (diff) | |
| download | php-shirabe-da6f05c12d08ac96b4286664cd8205d3fee042d8.tar.gz php-shirabe-da6f05c12d08ac96b4286664cd8205d3fee042d8.tar.zst php-shirabe-da6f05c12d08ac96b4286664cd8205d3fee042d8.zip | |
feat(phase-c): resolve owned-argument phase-b TODOs
Replace value-by-value signature workarounds with proper ownership:
- validate_json_schema: borrow JsonFile via ValidateJsonInput<&JsonFile>,
restoring the dropped local auth file validation call
- Auditor::audit / Solver::new / create_pool: pass cloned Rc handles and
share Pool via Rc<RefCell<Pool>>; create_pool now takes &mut Request
- MarkAlias{Installed,Uninstalled}Operation: hand over AliasPackageHandle
from the alias-confirmed branch
- dispatch_installer_event: clone the base Transaction (Rc-backed
contents) and enable the PRE_OPERATIONS_EXEC dispatch
- SuggestedPackagesReporter: share between command and installer via
Rc<RefCell<>> to mirror PHP reference semantics
PrePoolCreateEvent remains a TODO: it is plugin-only and would require a
speculative Rc migration of Request whose payload is never read today.
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/local_repo_transaction.rs')
| -rw-r--r-- | crates/shirabe/src/dependency_resolver/local_repo_transaction.rs | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs b/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs index eb77add..e592741 100644 --- a/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs +++ b/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs @@ -26,4 +26,8 @@ impl LocalRepoTransaction { pub fn get_operations(&self) -> &Vec<std::rc::Rc<dyn OperationInterface>> { self.inner.get_operations() } + + pub(crate) fn to_transaction(&self) -> Transaction { + self.inner.clone() + } } |
