diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-05 02:42:02 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-05 02:42:02 +0900 |
| commit | 9a25fcfc82b72f60facd381786ca5490acca032c (patch) | |
| tree | b34b36c19f14d57d160b8e4235a8040011bdec60 /crates/shirabe/src/dependency_resolver/operation | |
| parent | 886ee829cb191745167dca369045acd3125e5714 (diff) | |
| download | php-shirabe-9a25fcfc82b72f60facd381786ca5490acca032c.tar.gz php-shirabe-9a25fcfc82b72f60facd381786ca5490acca032c.tar.zst php-shirabe-9a25fcfc82b72f60facd381786ca5490acca032c.zip | |
feat(dependency-resolver): share operations via Rc, drop clone_box
OperationInterface::clone_box (a todo!() trait-object clone stub) is
removed in favor of Rc<dyn OperationInterface> shared ownership. All its
methods are &self, so operations are immutable value objects that Rc can
share; pushing the same operation into multiple lists (installer's
install/uninstall splits) becomes a cheap Rc clone instead of clone_box.
Box<dyn OperationInterface> is replaced with Rc<dyn ...> across
Transaction (and its Lock/LocalRepo wrappers), Installer, PackageEvent,
InstallationManager and EventDispatcher; Box::new operation constructions
become Rc::new.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/operation')
| -rw-r--r-- | crates/shirabe/src/dependency_resolver/operation/operation_interface.rs | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs b/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs index 3c24ff4..51b150c 100644 --- a/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs +++ b/crates/shirabe/src/dependency_resolver/operation/operation_interface.rs @@ -13,10 +13,6 @@ pub trait OperationInterface: std::fmt::Debug { fn to_string(&self) -> String; - fn clone_box(&self) -> Box<dyn OperationInterface> { - todo!() - } - fn as_install_operation(&self) -> Option<&InstallOperation> { None } |