aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/dependency_resolver/transaction.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-06 04:22:46 +0900
committernsfisis <nsfisis@gmail.com>2026-08-06 04:23:22 +0900
commit3d4a0cadc950d4440251efa11b55b0bfb0afdef7 (patch)
treecf1cd680867b9aa633eafe6332b881711b738823 /crates/shirabe/src/dependency_resolver/transaction.rs
parentce6192f1cfaac63457b173f573ada661a4665bfb (diff)
downloadphp-shirabe-3d4a0cadc950d4440251efa11b55b0bfb0afdef7.tar.gz
php-shirabe-3d4a0cadc950d4440251efa11b55b0bfb0afdef7.tar.zst
php-shirabe-3d4a0cadc950d4440251efa11b55b0bfb0afdef7.zip
chore: drop @param/@return tags that only restate Rust types
The ported docblocks copied @param and @return straight from the PHP source. When such a tag carries nothing but a type and an argument name, the Rust signature already states it, so the line is noise. Tags whose text adds prose beyond the type are kept. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/dependency_resolver/transaction.rs')
-rw-r--r--crates/shirabe/src/dependency_resolver/transaction.rs9
1 files changed, 0 insertions, 9 deletions
diff --git a/crates/shirabe/src/dependency_resolver/transaction.rs b/crates/shirabe/src/dependency_resolver/transaction.rs
index 4abe85d4..78037338 100644
--- a/crates/shirabe/src/dependency_resolver/transaction.rs
+++ b/crates/shirabe/src/dependency_resolver/transaction.rs
@@ -47,8 +47,6 @@ impl Default for Transaction {
}
impl Transaction {
- /// @param PackageInterface[] $presentPackages
- /// @param PackageInterface[] $resultPackages
pub fn new(
present_packages: Vec<PackageInterfaceHandle>,
result_packages: Vec<PackageInterfaceHandle>,
@@ -68,7 +66,6 @@ impl Transaction {
&self.operations
}
- /// @param PackageInterface[] $resultPackages
fn set_result_package_maps(&mut self, result_packages: Vec<PackageInterfaceHandle>) {
let package_sort = |a: &PackageInterfaceHandle, b: &PackageInterfaceHandle| -> i64 {
// sort alias packages by the same name behind their non alias version
@@ -107,7 +104,6 @@ impl Transaction {
}
}
- /// @return OperationInterface[]
pub(crate) fn calculate_operations(&mut self) -> Vec<AnyOperation> {
let mut operations: Vec<AnyOperation> = vec![];
@@ -222,8 +218,6 @@ impl Transaction {
///
/// These serve as a starting point to enumerate packages in a topological order despite potential cycles.
/// If there are packages with a cycle on the top level the package with the lowest name gets picked
- ///
- /// @return array<string, PackageInterface>
pub(crate) fn get_root_packages(&self) -> IndexMap<String, PackageInterfaceHandle> {
let mut roots: IndexMap<String, PackageInterfaceHandle> = self
.result_package_map
@@ -251,7 +245,6 @@ impl Transaction {
roots
}
- /// @return PackageInterface[]
pub(crate) fn get_providers_in_result(&self, link: &Link) -> Vec<PackageInterfaceHandle> {
let Some(packages) = self.result_packages_by_name.get(link.get_target()) else {
return vec![];
@@ -269,7 +262,6 @@ impl Transaction {
/// it at least fixes the symptoms and makes usage of composer possible (again)
/// in such scenarios.
///
- /// @param OperationInterface[] $operations
/// @return OperationInterface[] reordered operation list
fn move_plugins_to_front(&self, mut operations: Vec<AnyOperation>) -> Vec<AnyOperation> {
let mut dl_modifying_plugins_no_deps: Vec<AnyOperation> = vec![];
@@ -370,7 +362,6 @@ impl Transaction {
/// Removals of packages should be executed before installations in
/// case two packages resolve to the same path (due to custom installers)
///
- /// @param OperationInterface[] $operations
/// @return OperationInterface[] reordered operation list
fn move_uninstalls_to_front(&self, mut operations: Vec<AnyOperation>) -> Vec<AnyOperation> {
let mut uninst_ops: Vec<AnyOperation> = vec![];