diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:41:34 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:46:18 +0900 |
| commit | 2d474e91e49c7343d28198eff2b5bbbed9afbcee (patch) | |
| tree | 8c1ab321dfa5ddc1ca9d2871eb06a6fde6b2970b /crates/shirabe/src/downloader | |
| parent | e583112899cbea7494ffdd73d7de380dd5f808c4 (diff) | |
| download | php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.gz php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.zst php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.zip | |
feat(phase-c): resolve cross-module phase-b TODOs
Diffstat (limited to 'crates/shirabe/src/downloader')
| -rw-r--r-- | crates/shirabe/src/downloader/file_downloader.rs | 7 | ||||
| -rw-r--r-- | crates/shirabe/src/downloader/git_downloader.rs | 3 |
2 files changed, 1 insertions, 9 deletions
diff --git a/crates/shirabe/src/downloader/file_downloader.rs b/crates/shirabe/src/downloader/file_downloader.rs index 54b0882..e5112cc 100644 --- a/crates/shirabe/src/downloader/file_downloader.rs +++ b/crates/shirabe/src/downloader/file_downloader.rs @@ -551,12 +551,7 @@ impl DownloaderInterface for FileDownloader { for bin in package.get_binaries() { let bin_path = format!("{}/{}", path, bin); if file_exists(&bin_path) && !is_executable(&bin_path) { - // TODO(phase-b): Silencer::call_named for native PHP function - let _ = Silencer::call(|| { - let _ = bin_path; - let _ = umask(); - Ok(()) - }); + let _ = Silencer::call(|| Ok(shirabe_php_shim::chmod(&bin_path, 0o777 & !umask()))); } } diff --git a/crates/shirabe/src/downloader/git_downloader.rs b/crates/shirabe/src/downloader/git_downloader.rs index 7dace1b..47dd959 100644 --- a/crates/shirabe/src/downloader/git_downloader.rs +++ b/crates/shirabe/src/downloader/git_downloader.rs @@ -1240,7 +1240,6 @@ impl VcsDownloader for GitDownloader { io_interface::NORMAL, ); let slice_end = 10_usize.min(changes.len()); - // TODO(phase-b): PHP passes the list directly to writeError; joined here so write_error3 takes &str self.inner .io .write_error3(&changes[..slice_end].join("\n"), true, io_interface::NORMAL); @@ -1291,7 +1290,6 @@ impl VcsDownloader for GitDownloader { .into()); } Some("v") => { - // TODO(phase-b): PHP passes list directly; joined here for &str arg self.inner .io .write_error3(&changes.join("\n"), true, io_interface::NORMAL); @@ -1307,7 +1305,6 @@ impl VcsDownloader for GitDownloader { if do_help { // help: - // TODO(phase-b): PHP passes list directly; joined here for &str arg self.inner.io.write_error3( &[ format!( |