aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src/installer/installation_manager.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-02 16:27:36 +0900
committernsfisis <nsfisis@gmail.com>2026-08-02 16:29:08 +0900
commit9efc866ae2553a9c51abae7214f62dde4f5f053c (patch)
treed3749ced8b4e32713d4f5e3e88a34b501c4b4918 /crates/shirabe/src/installer/installation_manager.rs
parent6047bcc3e63ab84dfc67bce94f402f1bfa3f58d5 (diff)
downloadphp-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.gz
php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.tar.zst
php-shirabe-9efc866ae2553a9c51abae7214f62dde4f5f053c.zip
chore(todo): consolidate TODO comments into the five fixed marker tags
Retag every Shirabe-authored TODO comment to one of the fixed tags: phase-c, phase-d, plugin, php-runtime, phase-e. Upstream-authored TODO comments from Composer/Symfony are left untouched to preserve the ported code shape. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/installer/installation_manager.rs')
-rw-r--r--crates/shirabe/src/installer/installation_manager.rs8
1 files changed, 4 insertions, 4 deletions
diff --git a/crates/shirabe/src/installer/installation_manager.rs b/crates/shirabe/src/installer/installation_manager.rs
index 3a04a8e9..cf75469c 100644
--- a/crates/shirabe/src/installer/installation_manager.rs
+++ b/crates/shirabe/src/installer/installation_manager.rs
@@ -308,9 +308,9 @@ impl InstallationManager {
SignalHandler::SIGTERM.to_string(),
SignalHandler::SIGHUP.to_string(),
],
- // TODO(phase-b): closure captures &mut self via &mut cleanup_promises
+ // TODO(phase-c): closure captures &mut self via &mut cleanup_promises
Box::new(move |signal: String, handler: &SignalHandler| {
- // TODO(phase-b): self.io.write_error(...); self.run_cleanup(&cleanup_promises);
+ // TODO(phase-c): self.io.write_error(...); self.run_cleanup(&cleanup_promises);
let _ = signal;
handler.exit_with_last_signal();
}),
@@ -802,7 +802,7 @@ impl InstallationManager {
return;
}
- // TODO(phase-c-promise): PHP collects every http_downloader.add() promise and runs them via
+ // TODO(phase-c): PHP collects every http_downloader.add() promise and runs them via
// Loop::wait; the single-threaded sync bridge block_on's each notification serially instead.
let result: anyhow::Result<()> = (|| -> anyhow::Result<()> {
for (repo_url, packages) in self.notifiable_packages.borrow().iter() {
@@ -929,7 +929,7 @@ impl InstallationManager {
/// PHP: waitOnPromises() creates a ProgressBar up front and Loop::wait advances it while the
/// concurrent promises resolve.
- /// TODO(phase-c-promise): Loop::wait has no active-job counter to feed the bar yet, so a
+ /// TODO(phase-c): Loop::wait has no active-job counter to feed the bar yet, so a
/// single 0% -> 100% jump is rendered after the wait instead of PHP's timing-driven
/// intermediate snapshots.
async fn wait_on_promises<'p>(