diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:41:34 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-10 02:46:18 +0900 |
| commit | 2d474e91e49c7343d28198eff2b5bbbed9afbcee (patch) | |
| tree | 8c1ab321dfa5ddc1ca9d2871eb06a6fde6b2970b /crates/shirabe/src/io/buffer_io.rs | |
| parent | e583112899cbea7494ffdd73d7de380dd5f808c4 (diff) | |
| download | php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.gz php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.tar.zst php-shirabe-2d474e91e49c7343d28198eff2b5bbbed9afbcee.zip | |
feat(phase-c): resolve cross-module phase-b TODOs
Diffstat (limited to 'crates/shirabe/src/io/buffer_io.rs')
| -rw-r--r-- | crates/shirabe/src/io/buffer_io.rs | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/crates/shirabe/src/io/buffer_io.rs b/crates/shirabe/src/io/buffer_io.rs index 079b470..92f5714 100644 --- a/crates/shirabe/src/io/buffer_io.rs +++ b/crates/shirabe/src/io/buffer_io.rs @@ -59,8 +59,8 @@ impl BufferIO { } pub fn get_output(&self) -> String { - // TODO(phase-b): OutputInterface::get_stream returns PhpResource, while - // fseek/stream_get_contents take PhpMixed. Conversion is not yet defined. + // TODO(phase-c): OutputInterface::get_stream returns PhpResource, while + // fseek/stream_get_contents take PhpMixed. The PhpResource stream model is not yet defined. let stream: PhpMixed = todo!("PhpResource -> PhpMixed conversion for OutputInterface::get_stream"); fseek(stream.clone(), 0); @@ -93,7 +93,8 @@ impl BufferIO { &output, ); - // TODO(phase-b): Preg::replace_callback returns Result<String>, unwrap for now + // TODO(phase-c): Preg::replace_callback returns Result<String>; PHP getOutput returns the + // string directly, so this is gated on the get_stream PhpResource model above. output.unwrap_or_default() } |