diff options
Diffstat (limited to 'crates/shirabe/src/io/buffer_io.rs')
| -rw-r--r-- | crates/shirabe/src/io/buffer_io.rs | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/crates/shirabe/src/io/buffer_io.rs b/crates/shirabe/src/io/buffer_io.rs index 079b470..92f5714 100644 --- a/crates/shirabe/src/io/buffer_io.rs +++ b/crates/shirabe/src/io/buffer_io.rs @@ -59,8 +59,8 @@ impl BufferIO { } pub fn get_output(&self) -> String { - // TODO(phase-b): OutputInterface::get_stream returns PhpResource, while - // fseek/stream_get_contents take PhpMixed. Conversion is not yet defined. + // TODO(phase-c): OutputInterface::get_stream returns PhpResource, while + // fseek/stream_get_contents take PhpMixed. The PhpResource stream model is not yet defined. let stream: PhpMixed = todo!("PhpResource -> PhpMixed conversion for OutputInterface::get_stream"); fseek(stream.clone(), 0); @@ -93,7 +93,8 @@ impl BufferIO { &output, ); - // TODO(phase-b): Preg::replace_callback returns Result<String>, unwrap for now + // TODO(phase-c): Preg::replace_callback returns Result<String>; PHP getOutput returns the + // string directly, so this is gated on the get_stream PhpResource model above. output.unwrap_or_default() } |