diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-06 17:08:18 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-06 17:08:18 +0900 |
| commit | 71b432db3f115d17be498f36cd3efd40b4650a0b (patch) | |
| tree | 3dadf70e03a4a83d0ba428d1564e6a06bb588128 /crates/shirabe/src/package | |
| parent | 5c872cd39802739bfe5e21913b968fe0ae934830 (diff) | |
| download | php-shirabe-71b432db3f115d17be498f36cd3efd40b4650a0b.tar.gz php-shirabe-71b432db3f115d17be498f36cd3efd40b4650a0b.tar.zst php-shirabe-71b432db3f115d17be498f36cd3efd40b4650a0b.zip | |
refactor(version-bumper): share caller's VersionParser with ArrayLoader
Mirror PHP's "new ArrayLoader($parser)" by passing the existing parser
instead of None. VersionParser is stateless, so behavior is unchanged;
this drops the phase-b TODO.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Diffstat (limited to 'crates/shirabe/src/package')
| -rw-r--r-- | crates/shirabe/src/package/version/version_bumper.rs | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/crates/shirabe/src/package/version/version_bumper.rs b/crates/shirabe/src/package/version/version_bumper.rs index e54ad10..627a0fb 100644 --- a/crates/shirabe/src/package/version/version_bumper.rs +++ b/crates/shirabe/src/package/version/version_bumper.rs @@ -28,10 +28,7 @@ impl VersionBumper { let mut version = package.get_version().to_string(); if version.starts_with("dev-") { - // TODO(phase-b): ArrayLoader::new takes Option<VersionParser> by value; pass None until - // VersionParser sharing is reconciled. - let _ = &parser; - let loader = ArrayLoader::new(None, false); + let loader = ArrayLoader::new(Some(parser.clone()), false); let dumper = ArrayDumper::new(); let dumped = dumper.dump(package.clone()); let extra = loader.get_branch_alias(&dumped)?; |