refactor(repository): make read methods fallible and take &mut self

Change RepositoryInterface and WritableRepositoryInterface read methods
(find_package, find_packages, get_packages, load_packages, search,
get_providers, get_canonical_packages) to take &mut self and return
anyhow::Result, so lazy-loading repositories such as ComposerRepository
can perform fallible I/O and mutate internal state on access. Update all
implementors and call sites to propagate the Result and pass mutable
references.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 files changed, 5 insertions, 6 deletions

diff --git a/crates/shirabe/src/repository/canonical_packages_trait.rs b/crates/shirabe/src/repository/canonical_packages_trait.rs
index 5f0ecff..11088aa 100644
--- a/crates/shirabe/src/repository/canonical_packages_trait.rs
+++ b/crates/shirabe/src/repository/canonical_packages_trait.rs
@@ -1,15 +1,14 @@
 //! ref: composer/src/Composer/Repository/CanonicalPackagesTrait.php
 
 use crate::package::PackageInterfaceHandle;
+use crate::repository::RepositoryInterface;
 use indexmap::IndexMap;
 
 /// Provides get_canonical_packages() to various repository implementations.
-pub trait CanonicalPackagesTrait {
-    fn get_packages(&self) -> Vec<PackageInterfaceHandle>;
-
+pub trait CanonicalPackagesTrait: RepositoryInterface {
     /// Get unique packages (at most one package of each name), with aliases resolved and removed.
-    fn get_canonical_packages(&self) -> Vec<PackageInterfaceHandle> {
-        let packages = self.get_packages();
+    fn get_canonical_packages(&mut self) -> anyhow::Result<Vec<PackageInterfaceHandle>> {
+        let packages = self.get_packages()?;
 
         // get at most one package of each name, preferring non-aliased ones
         let mut packages_by_name: IndexMap<String, PackageInterfaceHandle> = IndexMap::new();
@@ -34,6 +33,6 @@ pub trait CanonicalPackagesTrait {
             canonical_packages.push(package);
         }
 
-        canonical_packages
+        Ok(canonical_packages)
     }
 }