diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:08:22 +0900 |
| commit | a9f19862350c6fd3592d93515d869ffe07ecb399 (patch) | |
| tree | 3d2e97403d658476e9e42a1d179cd29b606240e2 /crates/shirabe/src/repository | |
| parent | c935842b0c0c2d2c62b3a718ebe0017b7b192318 (diff) | |
| download | php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.gz php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.tar.zst php-shirabe-a9f19862350c6fd3592d93515d869ffe07ecb399.zip | |
feat: resolve trivial todo!() sites with existing constructors
Replace todo!("VersionParser::new()") with VersionParser::new() at 6
call sites (array_loader, base_command, create_project_command,
vcs_repository, http_downloader x2) and EventDispatcher::io_clone with
self.io.clone(). All targets already exist on their types.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/repository')
| -rw-r--r-- | crates/shirabe/src/repository/vcs_repository.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs index 804ba51..7a570c6 100644 --- a/crates/shirabe/src/repository/vcs_repository.rs +++ b/crates/shirabe/src/repository/vcs_repository.rs @@ -296,8 +296,7 @@ impl VcsRepository { } .into()); } - // TODO(phase-b): VersionParser has no public `new` - self.version_parser = Some(todo!("VersionParser::new()")); + self.version_parser = Some(VersionParser::new()); if self.loader.is_none() { self.loader = Some(Box::new(ArrayLoader::new( Some(todo!("phase-b: clone VersionParser")), |