diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:07:47 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-04 21:07:47 +0900 |
| commit | c935842b0c0c2d2c62b3a718ebe0017b7b192318 (patch) | |
| tree | ad83bb7fc8d128790260e12ebbe25915b70e375c /crates/shirabe/src/util | |
| parent | 8181f57ec3428195ac822590257cb3c135e25b5d (diff) | |
| download | php-shirabe-c935842b0c0c2d2c62b3a718ebe0017b7b192318.tar.gz php-shirabe-c935842b0c0c2d2c62b3a718ebe0017b7b192318.tar.zst php-shirabe-c935842b0c0c2d2c62b3a718ebe0017b7b192318.zip | |
refactor: drop stale phase-b TODO comments resolved by current code
These TODOs describe work already done: writeError per-line iteration
(github, remote_filesystem, svn_downloader) and reference equality via
std::ptr::eq (download_manager). No behavior change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/src/util')
| -rw-r--r-- | crates/shirabe/src/util/github.rs | 1 | ||||
| -rw-r--r-- | crates/shirabe/src/util/remote_filesystem.rs | 3 |
2 files changed, 0 insertions, 4 deletions
diff --git a/crates/shirabe/src/util/github.rs b/crates/shirabe/src/util/github.rs index 650ae33..18958ca 100644 --- a/crates/shirabe/src/util/github.rs +++ b/crates/shirabe/src/util/github.rs @@ -114,7 +114,6 @@ impl GitHub { } note += &format!(" {}", date("Y-m-d Hi", None)); - // PHP: writeError(array) joins with newline. TODO(phase-b): writeError accepts array natively in Symfony. let (local_name, auth_name): (Option<String>, String) = { let cfg = self.config.borrow(); ( diff --git a/crates/shirabe/src/util/remote_filesystem.rs b/crates/shirabe/src/util/remote_filesystem.rs index 2773300..bd4aaa8 100644 --- a/crates/shirabe/src/util/remote_filesystem.rs +++ b/crates/shirabe/src/util/remote_filesystem.rs @@ -430,7 +430,6 @@ impl RemoteFilesystem { if !self.degraded_mode && strpos(&msg_owned, "Operation timed out").is_some() { self.degraded_mode = true; self.io.write_error3("", true, crate::io::NORMAL); - // TODO(phase-b): PHP writeError accepts an array of lines; joined here with newline. self.io.write_error3( &format!( "<error>{}</error>\n<error>Retrying with degraded mode, check https://getcomposer.org/doc/articles/troubleshooting.md#degraded-mode for more info</error>", @@ -579,7 +578,6 @@ impl RemoteFilesystem { } self.degraded_mode = true; - // TODO(phase-b): PHP writeError accepts an array of lines; joined here with newline. self.io.write_error3( &format!( "\n<error>Failed to decode response: {}</error>\n<error>Retrying with degraded mode, check https://getcomposer.org/doc/articles/troubleshooting.md#degraded-mode for more info</error>", @@ -670,7 +668,6 @@ impl RemoteFilesystem { if !self.degraded_mode && strpos(&msg_owned, "Operation timed out").is_some() { self.degraded_mode = true; self.io.write_error3("", true, crate::io::NORMAL); - // TODO(phase-b): PHP writeError accepts an array of lines; joined here with newline. self.io.write_error3( &format!( "<error>{}</error>\n<error>Retrying with degraded mode, check https://getcomposer.org/doc/articles/troubleshooting.md#degraded-mode for more info</error>", |