aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/src
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-19 15:20:26 +0900
committernsfisis <nsfisis@gmail.com>2026-07-19 17:53:42 +0900
commit82cd8e8051ef791b9224916a5e2060ad38c1f82b (patch)
tree32c1428f354c2f43df1819c5c5ee74dfdd6c403f /crates/shirabe/src
parenta3334ee267d3e905646bdb49c2edc8774ac8d966 (diff)
downloadphp-shirabe-82cd8e8051ef791b9224916a5e2060ad38c1f82b.tar.gz
php-shirabe-82cd8e8051ef791b9224916a5e2060ad38c1f82b.tar.zst
php-shirabe-82cd8e8051ef791b9224916a5e2060ad38c1f82b.zip
fix(update-command): un-ignore test_update by fixing 3 real bugs
test_update was skipped for a stale reason; running it uncovered three distinct bugs it was actually catching: - ApplicationTester::run never restored SHELL_VERBOSITY after Application::configureIO mutates it, so one dataset's -vv verbosity leaked into later runs sharing the process (Symfony's tester restores it in a finally block; the port dropped that). - Installer::do_install built its RepositorySet with a hardcoded empty temporary_constraints map instead of self.temporary_constraints, so --with never actually constrained the resolver. - BumpCommand was missing a <warning> tag pair around one of its output lines.
Diffstat (limited to 'crates/shirabe/src')
-rw-r--r--crates/shirabe/src/command/bump_command.rs2
-rw-r--r--crates/shirabe/src/installer.rs3
2 files changed, 2 insertions, 3 deletions
diff --git a/crates/shirabe/src/command/bump_command.rs b/crates/shirabe/src/command/bump_command.rs
index 8f27fcb8..4b09f14c 100644
--- a/crates/shirabe/src/command/bump_command.rs
+++ b/crates/shirabe/src/command/bump_command.rs
@@ -146,7 +146,7 @@ impl BumpCommand {
.is_some_and(|m| m.contains_key("type"))
{
io.write_error3(
- "If your package is not a library, you can explicitly specify the \"type\" by using \"composer config type project\".",
+ "<warning>If your package is not a library, you can explicitly specify the \"type\" by using \"composer config type project\".</warning>",
true,
io_interface::NORMAL,
);
diff --git a/crates/shirabe/src/installer.rs b/crates/shirabe/src/installer.rs
index 068b85c3..6d943ea7 100644
--- a/crates/shirabe/src/installer.rs
+++ b/crates/shirabe/src/installer.rs
@@ -1436,14 +1436,13 @@ impl Installer {
alias_normalized: alias.get("alias_normalized").cloned().unwrap_or_default(),
})
.collect();
- let temporary_constraints: IndexMap<String, AnyConstraint> = IndexMap::new();
let mut repository_set = RepositorySet::new(
&minimum_stability,
stability_flags,
root_aliases_input,
self.package.get_references().clone(),
root_requires,
- temporary_constraints,
+ self.temporary_constraints.clone(),
);
repository_set.add_repository(crate::repository::RepositoryInterfaceHandle::new(
RootPackageRepository::new(self.fixed_root_package.clone()),