diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-07-20 16:04:45 +0900 |
| commit | 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 (patch) | |
| tree | b19a5500eb19c35f0f9fcee1b7f3213df2dade11 /crates/shirabe/tests/downloader | |
| parent | 80228e0a3b883ccdf2d80ba544c01619a856ef9c (diff) | |
| download | php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.gz php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.tar.zst php-shirabe-37ed5b8c6d4cda30e668d0221eb281431dbc8c67.zip | |
test(ignore): document root causes for unannotated #[ignore] tests
74 tests carried a bare #[ignore] with no explanation. Re-ran each:
25 now pass and had the attribute removed; the remaining 49 got a
concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type
mismatches, config bool-coercion bugs, missing skipped_load wiring
in PoolBuilder, etc.) so future work can find and fix them by grep.
No production code or test logic/assertions were changed.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/downloader')
| -rw-r--r-- | crates/shirabe/tests/downloader/archive_downloader_test.rs | 2 | ||||
| -rw-r--r-- | crates/shirabe/tests/downloader/xz_downloader_test.rs | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/crates/shirabe/tests/downloader/archive_downloader_test.rs b/crates/shirabe/tests/downloader/archive_downloader_test.rs index 77569e97..d1c736ca 100644 --- a/crates/shirabe/tests/downloader/archive_downloader_test.rs +++ b/crates/shirabe/tests/downloader/archive_downloader_test.rs @@ -110,7 +110,6 @@ fn provide_urls() -> Vec<&'static str> { } #[test] -#[ignore] fn test_process_url_rewrite_dist() { let downloader = get_archive_downloader(None); @@ -148,7 +147,6 @@ fn provide_bitbucket_urls() -> Vec<(&'static str, &'static str)> { } #[test] -#[ignore] fn test_process_url_rewrite_bitbucket_dist() { let downloader = get_archive_downloader(None); diff --git a/crates/shirabe/tests/downloader/xz_downloader_test.rs b/crates/shirabe/tests/downloader/xz_downloader_test.rs index db4659f9..c1fc6bc0 100644 --- a/crates/shirabe/tests/downloader/xz_downloader_test.rs +++ b/crates/shirabe/tests/downloader/xz_downloader_test.rs @@ -63,7 +63,7 @@ fn get_config(config_options: IndexMap<String, PhpMixed>, use_environment: bool) } #[cfg(all(not(windows), target_pointer_width = "64"))] -#[ignore] +#[ignore = "dist_url built from file!(), which yields a workspace-relative path unlike PHP's absolute __FILE__, so the file:// URL never resolves to a real file"] #[test] fn test_error_messages() { let test_dir = set_up(); |
