aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/downloader
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-07-25 16:16:33 +0900
committernsfisis <nsfisis@gmail.com>2026-07-25 16:17:10 +0900
commit432472808051cb4f1bb9517b858dbc810aaa5a63 (patch)
tree4c58b97942853ea2c3f58368203fa93187746cf8 /crates/shirabe/tests/downloader
parentd4608662f28b9a5135986b1702afe3199957eabe (diff)
downloadphp-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.gz
php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.tar.zst
php-shirabe-432472808051cb4f1bb9517b858dbc810aaa5a63.zip
refactor: replace redundant clones with moves
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/downloader')
-rw-r--r--crates/shirabe/tests/downloader/file_downloader_test.rs2
-rw-r--r--crates/shirabe/tests/downloader/git_downloader_test.rs4
-rw-r--r--crates/shirabe/tests/downloader/perforce_downloader_test.rs2
-rw-r--r--crates/shirabe/tests/downloader/zip_downloader_test.rs14
4 files changed, 11 insertions, 11 deletions
diff --git a/crates/shirabe/tests/downloader/file_downloader_test.rs b/crates/shirabe/tests/downloader/file_downloader_test.rs
index 623ac34c..65dc1a51 100644
--- a/crates/shirabe/tests/downloader/file_downloader_test.rs
+++ b/crates/shirabe/tests/downloader/file_downloader_test.rs
@@ -348,7 +348,7 @@ fn test_downgrade_shows_appropriate_message() {
},
);
- let io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>> = io_mock.clone();
+ let io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>> = io_mock;
let downloader = FileDownloader::new(
io,
config,
diff --git a/crates/shirabe/tests/downloader/git_downloader_test.rs b/crates/shirabe/tests/downloader/git_downloader_test.rs
index 748dfb14..65907567 100644
--- a/crates/shirabe/tests/downloader/git_downloader_test.rs
+++ b/crates/shirabe/tests/downloader/git_downloader_test.rs
@@ -986,7 +986,7 @@ fn test_downgrade_shows_appropriate_message() {
.borrow_mut()
.expects(vec![Expectation::text_regex("{Downgrading .*}")], false)
.unwrap();
- let io = io_mock.clone() as std::rc::Rc<std::cell::RefCell<dyn IOInterface>>;
+ let io = io_mock as std::rc::Rc<std::cell::RefCell<dyn IOInterface>>;
let mut fs = Filesystem::new(None);
fs.ensure_directory_exists(&format!("{}/.git", working_dir.path().to_string_lossy()))
@@ -1064,7 +1064,7 @@ fn test_not_using_downgrading_with_references() {
.borrow_mut()
.expects(vec![Expectation::text_regex("{Upgrading .*}")], false)
.unwrap();
- let io = io_mock.clone() as std::rc::Rc<std::cell::RefCell<dyn IOInterface>>;
+ let io = io_mock as std::rc::Rc<std::cell::RefCell<dyn IOInterface>>;
let mut fs = Filesystem::new(None);
fs.ensure_directory_exists(&format!("{}/.git", working_dir.path().to_string_lossy()))
diff --git a/crates/shirabe/tests/downloader/perforce_downloader_test.rs b/crates/shirabe/tests/downloader/perforce_downloader_test.rs
index c657e244..b1250906 100644
--- a/crates/shirabe/tests/downloader/perforce_downloader_test.rs
+++ b/crates/shirabe/tests/downloader/perforce_downloader_test.rs
@@ -141,7 +141,7 @@ fn do_install_workflow(source_ref: &'static str, expected_label: Option<String>)
false,
)
.unwrap();
- let io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>> = io_mock.clone();
+ let io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>> = io_mock;
let config = std::rc::Rc::new(std::cell::RefCell::new(get_config(test_path.path())));
let (process, _process_guard) =
get_process_executor_mock(vec![], false, MockHandler::default());
diff --git a/crates/shirabe/tests/downloader/zip_downloader_test.rs b/crates/shirabe/tests/downloader/zip_downloader_test.rs
index 8ec440d8..86f9968f 100644
--- a/crates/shirabe/tests/downloader/zip_downloader_test.rs
+++ b/crates/shirabe/tests/downloader/zip_downloader_test.rs
@@ -206,7 +206,7 @@ fn test_zip_archive_only_failed() {
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
let e = result.expect_err("expected RuntimeException");
assert!(
@@ -232,7 +232,7 @@ fn test_zip_archive_extract_only_failed() {
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
let e = result.expect_err("expected RuntimeException");
assert!(
@@ -260,7 +260,7 @@ fn test_zip_archive_only_good() {
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
result.expect("extract should succeed");
}
@@ -298,7 +298,7 @@ fn test_system_unzip_only_failed() {
let downloader = make_downloader_with_process(&set_up, process);
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
let e = result.expect_err("expected RuntimeException");
assert!(
@@ -331,7 +331,7 @@ fn test_system_unzip_only_good() {
let downloader = make_downloader_with_process(&set_up, process);
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
result.expect("extract should succeed");
}
@@ -365,7 +365,7 @@ fn test_non_windows_fallback_good() {
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
result.expect("extract should succeed");
}
@@ -399,7 +399,7 @@ fn test_non_windows_fallback_failed() {
downloader.__set_zip_archive_object(Some(zip_archive));
let filename = set_up.filename.to_string_lossy().into_owned();
- let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir"));
+ let result = run(downloader.extract(set_up.package, &filename, "vendor/dir"));
let e = result.expect_err("expected RuntimeException");
assert!(