diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-21 21:25:15 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-22 00:49:03 +0900 |
| commit | f691b864b687f251c3b266e8cff2774d730567ba (patch) | |
| tree | 86d361d44531240436fa6a55589acc206b9aae01 /crates/shirabe/tests/json | |
| parent | 8db88c2da2cf387bc58843ac5093bb15b9fc3252 (diff) | |
| download | php-shirabe-f691b864b687f251c3b266e8cff2774d730567ba.tar.gz php-shirabe-f691b864b687f251c3b266e8cff2774d730567ba.tar.zst php-shirabe-f691b864b687f251c3b266e8cff2774d730567ba.zip | |
test(php-shim): un-ignore tests now unblocked by implemented shims
Remove #[ignore] from tests gated solely on a shim function that is now
implemented, where the test passes:
- metapackage_installer::test_update (version_compare)
- platform_requirement_filter_factory::test_from_bool_throws... (get_debug_type)
- runtime::test_parse_extension_info (html_entity_decode/strip_tags)
- package_sorter::test_sorting_does_nothing... (strnatcasecmp)
- no_proxy_pattern::test_host_name/test_port (unpack/substr_count)
- version_parser::test_is_upgrade (version_compare)
- pool::test_what_provides_package_with_constraint
- proxy_item::test_throws_on_malformed_url
Update the ignore reason where the cited shim is now implemented but the
test still cannot pass for a different reason:
- no_proxy_pattern::test_ip_address/test_ip_range (IPv4-mapped IPv6 gap)
- package_sorter::test_sorting_orders... (look-around regex)
- proxy_item::test_url_formatting (parse_url host discrepancy)
- json_manipulator/json_config_source/filesystem_repository stubs
(test bodies are still todo!(), not yet ported)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/json')
| -rw-r--r-- | crates/shirabe/tests/json/json_manipulator_test.rs | 103 |
1 files changed, 50 insertions, 53 deletions
diff --git a/crates/shirabe/tests/json/json_manipulator_test.rs b/crates/shirabe/tests/json/json_manipulator_test.rs index a3ede89..7cf8e87 100644 --- a/crates/shirabe/tests/json/json_manipulator_test.rs +++ b/crates/shirabe/tests/json/json_manipulator_test.rs @@ -1,304 +1,301 @@ //! ref: composer/tests/Composer/Test/Json/JsonManipulatorTest.php -// JsonManipulator's text-rewriting operations reach addcslashes, which is todo!() in the -// php-shim, so none of these cases can run yet. - #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_link() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_link_and_sort_packages() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_sub_node() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_sub_node_from_require() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_sub_node_preserves_object_type_when_empty() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_sub_node_preserves_object_type_when_empty2() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_sub_node_in_require() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_extra_with_package() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_with_package() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_suggest_with_package() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_can_initialize_empty_repositories() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_can_initialize_from_scratch() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_can_append() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_can_prepend() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_can_override_deep_repos() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_set_url_in_repository() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_insert_repository_before_and_after_by_name() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_repository_removes_from_assoc_but_does_not_converts_from_assoc_to_list() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_repository_removes_from_list() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_converts_from_assoc_to_list() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_escapes() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_works_from_scratch() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_add() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_overwrite() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_overwrite_numbers() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_overwrite_arrays() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_add_sub_key_in_empty_config() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_add_sub_key_in_empty_val() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_config_setting_can_add_sub_key_in_hash() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_root_setting_does_not_break_dots() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_config_setting_can_remove_sub_key_in_hash() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_config_setting_can_remove_sub_key_in_hash_with_siblings() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_main_key() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_main_key_with_content_having_dollar_sign_followed_by_digit() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_main_key_with_content_having_dollar_sign_followed_by_digit2() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_update_main_key() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_update_main_key2() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_update_main_key3() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_update_main_key_with_content_having_dollar_sign_followed_by_digit() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_main_key() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_main_key_if_empty() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_main_key_removes_key_where_value_is_null() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_indent_detection() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_main_key_at_end_of_file() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_list_item() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_list_item() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_insert_list_item() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_escaped_unicode_does_not_cause_backtrack_limit_error_github_issue8131() { todo!() } #[test] -#[ignore = "JsonManipulator operations reach addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_large_file_does_not_cause_backtrack_limit_error_github_issue9595() { todo!() } |
