aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/util/ini_helper_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
committernsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
commit5ab5f3b316798c1411ce8e6a7f5b091fda93589c (patch)
treec7669f94f5d9bd9adc07bc1aab3f14cfdec1ae5f /crates/shirabe/tests/util/ini_helper_test.rs
parentb291e714bc739262140323e08fe2fb9e91e00ee7 (diff)
downloadphp-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.gz
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.zst
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.zip
test: port previously-ignored Composer tests via __ test hatches
Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/util/ini_helper_test.rs')
-rw-r--r--crates/shirabe/tests/util/ini_helper_test.rs15
1 files changed, 8 insertions, 7 deletions
diff --git a/crates/shirabe/tests/util/ini_helper_test.rs b/crates/shirabe/tests/util/ini_helper_test.rs
index 59dc967..f511d76 100644
--- a/crates/shirabe/tests/util/ini_helper_test.rs
+++ b/crates/shirabe/tests/util/ini_helper_test.rs
@@ -7,10 +7,11 @@ use shirabe_php_shim::{PATH_SEPARATOR, getenv, putenv};
#[allow(dead_code)]
fn set_up() -> TearDown {
// Register our name with XdebugHandler.
- // TODO: XdebugHandler is the external composer/xdebug-handler package and is not ported.
- todo!();
+ // The PHP test constructs `new XdebugHandler('composer')` so that
+ // getAllIniFiles() reads the COMPOSER_ORIGINAL_INIS env var. The Rust
+ // XdebugHandler is a unit struct with no name-registration API, so this
+ // step is a no-op here.
// Save current state
- #[allow(unreachable_code)]
let env_original = getenv("COMPOSER_ORIGINAL_INIS");
TearDown { env_original }
}
@@ -44,7 +45,7 @@ fn set_env(paths: &[&str]) {
}
#[test]
-#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"]
+#[ignore]
fn test_with_no_ini() {
let paths = [""];
@@ -57,7 +58,7 @@ fn test_with_no_ini() {
}
#[test]
-#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"]
+#[ignore]
fn test_with_loaded_ini_only() {
let paths = ["loaded.ini"];
@@ -66,7 +67,7 @@ fn test_with_loaded_ini_only() {
}
#[test]
-#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"]
+#[ignore]
fn test_with_loaded_ini_and_additional() {
let paths = ["loaded.ini", "one.ini", "two.ini"];
@@ -79,7 +80,7 @@ fn test_with_loaded_ini_and_additional() {
}
#[test]
-#[ignore = "IniHelper::get_all reaches XdebugHandler::get_all_ini_files, which is todo!()"]
+#[ignore]
fn test_without_loaded_ini_and_additional() {
let paths = ["", "one.ini", "two.ini"];