aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/util/tar_test.rs
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
committernsfisis <nsfisis@gmail.com>2026-06-22 23:42:07 +0900
commit5ab5f3b316798c1411ce8e6a7f5b091fda93589c (patch)
treec7669f94f5d9bd9adc07bc1aab3f14cfdec1ae5f /crates/shirabe/tests/util/tar_test.rs
parentb291e714bc739262140323e08fe2fb9e91e00ee7 (diff)
downloadphp-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.gz
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.tar.zst
php-shirabe-5ab5f3b316798c1411ce8e6a7f5b091fda93589c.zip
test: port previously-ignored Composer tests via __ test hatches
Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/util/tar_test.rs')
-rw-r--r--crates/shirabe/tests/util/tar_test.rs14
1 files changed, 7 insertions, 7 deletions
diff --git a/crates/shirabe/tests/util/tar_test.rs b/crates/shirabe/tests/util/tar_test.rs
index 6234108..48f1cbe 100644
--- a/crates/shirabe/tests/util/tar_test.rs
+++ b/crates/shirabe/tests/util/tar_test.rs
@@ -12,7 +12,7 @@ fn fixture(name: &str) -> String {
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_returns_nullif_the_tar_is_not_found() {
let result = Tar::get_composer_json(&fixture("invalid.zip")).unwrap();
@@ -20,26 +20,26 @@ fn test_returns_nullif_the_tar_is_not_found() {
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_returns_null_if_the_tar_is_empty() {
let result = Tar::get_composer_json(&fixture("empty.tar.gz")).unwrap();
assert_eq!(None, result);
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_throws_exception_if_the_tar_has_no_composer_json() {
assert!(Tar::get_composer_json(&fixture("nojson.tar.gz")).is_err());
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_throws_exception_if_the_composer_json_is_in_a_sub_subfolder() {
assert!(Tar::get_composer_json(&fixture("subfolders.tar.gz")).is_err());
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_returns_composer_json_in_tar_root() {
let result = Tar::get_composer_json(&fixture("root.tar.gz")).unwrap();
assert_eq!(
@@ -49,7 +49,7 @@ fn test_returns_composer_json_in_tar_root() {
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_returns_composer_json_in_first_folder() {
let result = Tar::get_composer_json(&fixture("folder.tar.gz")).unwrap();
assert_eq!(
@@ -59,7 +59,7 @@ fn test_returns_composer_json_in_first_folder() {
}
#[test]
-#[ignore = "PharData::new is todo!() in the php-shim"]
+#[ignore]
fn test_multiple_top_level_dirs_is_invalid() {
assert!(Tar::get_composer_json(&fixture("multiple.tar.gz")).is_err());
}