diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-06-28 07:16:42 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-06-28 07:20:32 +0900 |
| commit | 0bf96f5de11555ddfdcde81c0a27869afeaf5832 (patch) | |
| tree | f44aa2e365dec17b532b784667ba836d734857e8 /crates/shirabe/tests/documentation_test.rs | |
| parent | f74d43409220ac209d01367bfc40dbc2c85be252 (diff) | |
| download | php-shirabe-0bf96f5de11555ddfdcde81c0a27869afeaf5832.tar.gz php-shirabe-0bf96f5de11555ddfdcde81c0a27869afeaf5832.tar.zst php-shirabe-0bf96f5de11555ddfdcde81c0a27869afeaf5832.zip | |
test(console): correct inaccurate test skip reasons
setCatchErrors is an old-Symfony compatibility shim that exists in
neither Composer's PHP class nor Shirabe, and setAutoExit(false) is the
default in Shirabe, so neither is a reason a test is unportable. Drop
those mentions and point the application_test ignores at the real
blocker: do_run's script-command registration is still a todo!().
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/documentation_test.rs')
| -rw-r--r-- | crates/shirabe/tests/documentation_test.rs | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/crates/shirabe/tests/documentation_test.rs b/crates/shirabe/tests/documentation_test.rs index 07694d8..4fe9a94 100644 --- a/crates/shirabe/tests/documentation_test.rs +++ b/crates/shirabe/tests/documentation_test.rs @@ -18,8 +18,6 @@ fn get_command_name(command: &Rc<RefCell<dyn Command>>) -> String { fn provide_command_cases() -> Vec<Rc<RefCell<dyn Command>>> { let application = ApplicationHandle::new("Composer".to_string(), "".to_string()).unwrap(); - // setAutoExit(false) is the default in Shirabe. The setCatchErrors() call is guarded by - // method_exists() in PHP and has no Rust equivalent. application.set_catch_exceptions(false); let mut description = |